Skip to content

Commit 760f73e

Browse files
committed
fix(artifactory): ignore extensions without a manifest
This ignores extensions where the manifest download from artifactory failed instead of crashing the process with a segfault. It fixes #68
1 parent 2da8330 commit 760f73e

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

storage/artifactory.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,13 @@ func (s *Artifactory) WalkExtensions(ctx context.Context, fn func(manifest *VSIX
405405
return err
406406
}
407407
for _, ext := range extensions {
408+
if ext.manifest == nil {
409+
id := ExtensionID(ext.publisher, ext.name, ext.versions[0].Version)
410+
s.logger.Warn(ctx, "Ignore extension with missing manifest",
411+
slog.F("id", id),
412+
slog.F("targetPlatform", ext.versions[0].TargetPlatform))
413+
continue
414+
}
408415
if err = fn(ext.manifest, ext.versions); err != nil {
409416
return err
410417
}

0 commit comments

Comments
 (0)