Do not return any error when matching was successful (#162)

* Do not return any error when matching was successful

* CS Fixes

* Fix failing tests on old php version

* Ops, forgot to remove one void return type :P

Author: norberttech

src/Matcher.php

@@ -17,7 +17,13 @@ public function __construct(ValueMatcher $matcher)
 
     public function match($value, $pattern) : bool
     {
-        return $this->matcher->match($value, $pattern);
+        $result = $this->matcher->match($value, $pattern);
+
+        if ($result === true) {
+            $this->matcher->clearError();
+        }
+
+        return $result;
     }
 
     /**

src/Matcher/Matcher.php

@@ -27,4 +27,9 @@ public function match($value, $pattern) : bool
 
         return false;
     }
+
+    public function clearError()
+    {
+        $this->error = null;
+    }
 }

src/Matcher/ValueMatcher.php

@@ -22,4 +22,9 @@ public function canMatch($pattern) : bool;
      * @return null|string
      */
     public function getError();
+
+    /**
+     * Clear last error
+     */
+    public function clearError();
 }

tests/Matcher/JsonMatcherTest.php

@@ -126,6 +126,15 @@ public function test_error_when_json_pattern_is_invalid()
         $this->assertEquals($this->matcher->getError(), 'Invalid given JSON of pattern. Syntax error, malformed JSON');
     }
 
+    /**
+     * Solves https://github.com/coduo/php-matcher/issues/156
+     */
+    public function test_empty_error_after_successful_match()
+    {
+        $this->assertTrue($this->matcher->match($value = '{"foo": "bar"}', $pattern = '{"foo": "@string@"}'));
+        $this->assertNull($this->matcher->getError());
+    }
+
     public function test_error_when_json_value_is_invalid()
     {
         $value = '{"test": "value",}';

tests/MatcherTest.php

@@ -62,7 +62,7 @@ public function test_matcher_with_array_value()
             'data' => '@wildcard@',
         ];
 
-        $this->assertTrue($this->matcher->match($value, $expectation), $this->matcher->getError());
+        $this->assertTrue($this->matcher->match($value, $expectation), (string) $this->matcher->getError());
         $this->assertTrue(PHPMatcher::match($value, $expectation, $error), (string) $error);
     }