update deps to phpunit 6.x, fix code and tests #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberttech
reviewed
Jul 18, 2017
.travis.yml
Outdated
| - php: hhvm | ||
|
|
||
| before_install: | ||
| - composer self-update | ||
|
|
||
| install: | ||
| - export COMPOSER_ROOT_VERSION=dev-master | ||
| - if [ "$DEPENDENCIES" != "low" ]; then composer update; fi; | ||
| - if [ "$DEPENDENCIES" == "low" ]; then composer update --prefer-lowest; fi; |
There was a problem hiding this comment.
I don't like removing low dependencies tests, please bring back DEPENDENCIES='low' for php 7.0
There was a problem hiding this comment.
okay, thought it was depending on php version 5.3...
There was a problem hiding this comment.
low means that we are testing lowest possible versions of all dependencies
norberttech
reviewed
Jul 18, 2017
.travis.yml
Outdated
| - php: 7.0 | ||
| - php: 7.1 | ||
| - php: hhvm |
There was a problem hiding this comment.
I believe you can remove hhvm as well
There was a problem hiding this comment.
fine, recently saw that travis support for hhvm failed in this configuration...
|
overall this PR looks good but before I merge it I'll first stabilize version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #96