Skip to content

Empty array after mismatch fix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Empty array after mismatch fix #14

wants to merge 2 commits into from

Conversation

defrag
Copy link
Member

@defrag defrag commented May 29, 2014

Quick fix for #13. Im not sure its perfect tho, but tests are passing.

@pskt
Copy link
Contributor

pskt commented May 29, 2014

I think that this fix will fail in situation like:
pattern:

{
'foo' => 'foo val',
'bar' => 'bar val'
}

Value:

{
'foo' => 'foo val'
}

Because you added failure only when value is empty

@defrag
Copy link
Member Author

defrag commented May 29, 2014

I added assertion for this also. It passed. @norzechowicz will look at this issue, cuz i am not to happy about this quick fix, but dont have time right now to rework it :)

@norberttech
Copy link
Member

Closed in favor od #15

@defrag defrag deleted the patch1 branch May 29, 2014 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants