Do not use anymore child matcher errors in Json/XML matchers #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberttech
commented
Aug 15, 2019
| @@ -113,7 +112,7 @@ public function test_error_when_path_in_nested_value_does_not_exist() | |||
|
|
|||
| $this->assertFalse($this->matcher->match($value, $pattern)); | |||
|
|
|||
| $this->assertEquals($this->matcher->getError(), 'There is no element under path [foo][bar][faz] in value.'); | |||
| $this->assertEquals($this->matcher->getError(), 'Value {"foo":{"bar":[]}} does not match pattern {"foo":{"bar":{"faz":"faz value"}}}'); | |||
There was a problem hiding this comment.
this potentially might look opposite to increasing verbosity but I'm planning to create matcher backtrace that will let all matchers to put each operation into the backtrace, currently in most cases errors from JSON/XML matcher does not make any sense except situations like this one (it is handled in special way).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goal is to increase verbosity of Json/XML matchers error messages. It also deprecates SimpleFactory in favor of MatcherFactory (simple was terrible name) and simplifies factory building process.