Fixed JSON handling in PHPMatcherConstraint #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberttech
reviewed
Aug 12, 2020
|
Thank you @vudaltsov 🎉 |
norberttech
pushed a commit
to norberttech/php-matcher
that referenced
this pull request
Sep 27, 2020
* Fixed JSON handling in PHPMatcherConstraint * Move comma to the next line after nowdoc
norberttech
pushed a commit
to norberttech/php-matcher
that referenced
this pull request
Sep 27, 2020
* Fixed JSON handling in PHPMatcherConstraint * Move comma to the next line after nowdoc
|
Thanks @vudaltsov, that's great :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON values are supposed to be canonicalized, but it does not work, because the new json string is not assigned via array unpacking. This PR fixes the issue.
I also fixed the absence of
returnafterparent::fail($other, $description);by moving comparison failure construction to its own method and adding early returns.