Skip to content

Commit f1d824d

Browse files
committed
Don't switch to mypy v0.501 yet
But keep the improvements
1 parent 8ab39f9 commit f1d824d

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ mypy: ${PYSOURCES}
173173
rm -Rf typeshed/2.7/ruamel/yaml
174174
ln -s $(shell python -c 'from __future__ import print_function; import ruamel.yaml; import os.path; print(os.path.dirname(ruamel.yaml.__file__))') \
175175
typeshed/2.7/ruamel/
176-
MYPYPATH=typeshed/2.7 mypy --py2 --strict schema_salad/*.py
176+
MYPYPATH=typeshed/2.7 mypy --py2 --disallow-untyped-calls \
177+
--fast-parser --warn-redundant-casts --warn-unused-ignores \
178+
schema_salad
177179

178180
jenkins:
179181
rm -Rf env && virtualenv env

schema_salad/ref_resolver.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,16 +67,16 @@ def __init__(self, normalize=unicode): # type: (Callable) -> None
6767
self.normalize = normalize
6868

6969
def __getitem__(self, key): # type: (Any) -> Any
70-
return super(NormDict, self).__getitem__(self.normalize(key))
70+
return super(NormDict, self).__getitem__(self.normalize(key)) # type: ignore
7171

7272
def __setitem__(self, key, value): # type: (Any, Any) -> Any
7373
return super(NormDict, self).__setitem__(self.normalize(key), value)
7474

7575
def __delitem__(self, key): # type: (Any) -> Any
76-
return super(NormDict, self).__delitem__(self.normalize(key))
76+
return super(NormDict, self).__delitem__(self.normalize(key)) # type: ignore
7777

7878
def __contains__(self, key): # type: (Any) -> Any
79-
return super(NormDict, self).__contains__(self.normalize(key))
79+
return super(NormDict, self).__contains__(self.normalize(key)) # type: ignore
8080

8181

8282
def merge_properties(a, b): # type: (List[Any], List[Any]) -> Dict[Any, Any]
@@ -465,8 +465,7 @@ def resolve_ref(self,
465465
url = self.expand_url(lref, base_url, scoped_id=(obj is not None))
466466
# Has this reference been loaded already?
467467
if url in self.idx and (not mixin):
468-
return cast(Union[CommentedMap, CommentedSeq, unicode],
469-
self.idx[url]), {}
468+
return self.idx[url], {}
470469

471470
sl.raise_type = RuntimeError
472471
with sl:

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ deps = -rrequirements.txt
1414
commands = make mypy
1515
whitelist_externals = make
1616
deps =
17-
mypy>=0.501
17+
mypy==0.470
1818
typed-ast==0.6.3
1919
-rrequirements.txt
2020

2121
[testenv:py35-mypy]
2222
commands = make mypy
2323
whitelist_externals = make
2424
deps =
25-
mypy>=0.501
25+
mypy==0.470
2626
typed-ast==0.6.3
2727
-rrequirements.txt
2828

0 commit comments

Comments
 (0)