Skip to content

Commit ffc8f21

Browse files
committed
pass CWL tests with singularity, except for #82
1 parent 0e8f1ef commit ffc8f21

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

cwltool/job.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ def run(self, pull_image=True, rm_container=True,
507507
for t, v in self.environment.items():
508508
runtime.append(u"--env=%s=%s" % (t, v))
509509
elif container_manager == "singularity":
510-
runtime = [u"singularity", u"exec"]
510+
runtime = [u"singularity", u"--quiet", u"exec"]
511511

512512
runtime.append(u"--bind")
513513
runtime.append(
@@ -533,7 +533,7 @@ def run(self, pull_image=True, rm_container=True,
533533
for t, v in self.environment.items():
534534
env["SINGULARITYENV_" + t] = v
535535

536-
runtime.append(img_id)
536+
runtime.append("docker://" + img_id)
537537

538538
self._execute(
539539
runtime, env, rm_tmpdir=rm_tmpdir, move_outputs=move_outputs)
@@ -616,7 +616,7 @@ def _job_popen(
616616
stdin_path=stdin_path,
617617
)
618618
with open(os.path.join(job_dir, "job.json"), "wb") as f:
619-
json.dump(job_description, codecs.getwriter('utf-8')(f), ensure_ascii=False) # type: ignore
619+
json.dump(job_description, codecs.getwriter('utf-8')(f), ensure_ascii=False) # type: ignore
620620
try:
621621
job_script = os.path.join(job_dir, "run_job.bash")
622622
with open(job_script, "wb") as f:

jenkins.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
if [ "$JENKINS_URL" == ""]
2+
if [[ -z "${JENKINS_URL}" ]]
33
then
44
echo "Looks like we're not being run by Jenkins, this is dangerous"
55
echo "due to use of git clean -fdx command."

0 commit comments

Comments
 (0)