Skip to content

Commit 118292f

Browse files
patmarionjcfr
authored andcommitted
Update VTK wrapping to work for VTK <= 5.6
1 parent 9c466f2 commit 118292f

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ if(PythonQt_USE_VTK)
4545
find_package(VTK REQUIRED)
4646
include(${VTK_USE_FILE})
4747
add_definitions(-DPYTHONQT_USE_VTK)
48-
set(VTK_LIBRARIES vtkPythonCore)
48+
if(${VTK_VERSION_MAJOR}.${VTK_VERSION_MINOR} VERSION_GREATER 5.6)
49+
set(VTK_LIBRARIES vtkPythonCore)
50+
else()
51+
set(VTK_LIBRARIES vtkCommon)
52+
endif()
4953
else()
5054
remove_definitions(-DPYTHONQT_USE_VTK)
5155
endif()

src/PythonQt.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,11 @@ PyObject* PythonQtPrivate::wrapPtr(void* ptr, const QByteArray& name)
415415
if (name.startsWith("vtk"))
416416
{
417417
vtkObject * _vtkObj = reinterpret_cast<vtkObject*>(ptr);
418+
#if (VTK_MAJOR_VERSION == 5 && VTK_MINOR_VERSION <= 6) || VTK_MAJOR_VERSION < 5
419+
return vtkPythonGetObjectFromPointer(_vtkObj);
420+
#else
418421
return vtkPythonUtil::GetObjectFromPointer(_vtkObj);
422+
#endif
419423
}
420424
#endif
421425
wrap = createNewPythonQtInstanceWrapper(wrapper, info, ptr);

src/PythonQtConversion.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,11 @@ void* PythonQtConv::ConvertPythonToQt(const PythonQtMethodInfo::ParameterInfo& i
394394
}
395395
#ifdef PYTHONQT_USE_VTK
396396
else if (info.name.startsWith("vtk")) {
397+
#if (VTK_MAJOR_VERSION == 5 && VTK_MINOR_VERSION <= 6) || VTK_MAJOR_VERSION < 5
398+
vtkObjectBase * vtkObj = vtkPythonGetPointerFromObject(obj, info.name.data());
399+
#else
397400
vtkObjectBase * vtkObj = vtkPythonUtil::GetPointerFromObject(obj, info.name.data());
401+
#endif
398402
if (vtkObj) {
399403
PythonQtValueStorage_ADD_VALUE_IF_NEEDED(alreadyAllocatedCPPObject,global_ptrStorage, void*, vtkObj, ptr);
400404
}

0 commit comments

Comments
 (0)