Skip to content

Commit b85ef8a

Browse files
Francois Budinjcfr
authored andcommitted
Remove INSTALL_NAME_DIR target property
Using INSTALL_NAME_DIR target property forces the install name to be an absolute path instead of `@rpath/{target_name}` [1]. This causes problems when one tries to relocate the target once it is installed. This patch removes this target property. If a project needs to keep the absolute path, CMake variables such as INSTALL_NAME_DIR can be set at configuration to do so. [1] https://gitlab.kitware.com/cmake/cmake/issues/16589
1 parent 4572092 commit b85ef8a

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

CMakeLists.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -342,14 +342,6 @@ add_library(PythonQt SHARED
342342
)
343343
set_target_properties(PythonQt PROPERTIES DEFINE_SYMBOL PYTHONQT_EXPORTS)
344344

345-
#
346-
# That should solve linkage error on Mac when the project is used in a superbuild setup
347-
# See http://blog.onesadcookie.com/2008/01/installname-magic.html
348-
#
349-
set_target_properties(PythonQt PROPERTIES
350-
INSTALL_NAME_DIR "${CMAKE_INSTALL_PREFIX}/lib"
351-
)
352-
353345
target_link_libraries(PythonQt
354346
${PYTHON_LIBRARY}
355347
${QT_LIBRARIES}

0 commit comments

Comments
 (0)