added missing header and travis/osx #48
Conversation
|
Thanks for resuming work on this 👍 |
|
As a side note, branch patched-07 has been updated to work against the latest version of Qt and PythonQt. When things are stable ... we will contribute patches in upstream PythonQt. |
|
I've seen and I tried to get that and include in travis-ci, but unfortunately I have some problems with the linux build environment on travis which uses QT 5.2 and that version is really strange (the webkit is missing...) |
|
@iltommi Thanks for the patches. Based on the history of the branch, it looks like you need to support Qt5. If this is the case, I suggest you base your work on If only need to support Qt4, rebasing your changes on top of Reading here provides info on which branch are the current ones: https://github.com/commontk/PythonQt |
|
ok I'll jump to patched-8. I will add an issue I just discovered :) |
pip and some other Python modules use this attribute to check if they are running in an interactive console. fixes #48 Co-authored-by: Fernando Perez-Garcia <[email protected]>
I've added a header file (
src/gui/PythonQtScriptingConsole.h) in the install.I also added a travis file as first attempt to continuous integration.
It's not that much because it just check the compilation on osx, but it works. Anwone willing to add other os might find it helpful.
here is a sample of the pytohnqt compilation for osx : https://travis-ci.org/iltommi/PythonQt