Skip to content

Commit 0832894

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent c5966b7 commit 0832894

File tree

1 file changed

+174
-0
lines changed

1 file changed

+174
-0
lines changed

‎triage/2023-09-13.md

Lines changed: 174 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,174 @@
1+
# 2023-09-13 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [15e52b05ca8f63e0da27c808680388717e5b997e..7e0261e7ea2085bdc0bc3d0fd6776bf343473858](https://perf.rust-lang.org/?start=15e52b05ca8f63e0da27c808680388717e5b997e&end=7e0261e7ea2085bdc0bc3d0fd6776bf343473858&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 2.8% | [0.7%, 10.2%] | 11 |
13+
| Regressions ❌ <br /> (secondary) | 1.5% | [0.4%, 7.7%] | 9 |
14+
| Improvements ✅ <br /> (primary) | -1.7% | [-5.9%, -0.2%] | 112 |
15+
| Improvements ✅ <br /> (secondary) | -1.3% | [-2.7%, -0.4%] | 41 |
16+
| All ❌✅ (primary) | -1.3% | [-5.9%, 10.2%] | 123 |
17+
18+
19+
3 Regressions, 2 Improvements, 5 Mixed; ??? of them in rollups
20+
84 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Add `FreezeLock` type and use it to store `Definitions` [#115401](https://github.com/rust-lang/rust/pull/115401) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c1d80ba9e28a9248158ab09fe593b0724647e642&end=a0c28cd9dc99d9acb015d06f6b27c640adad3550&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 11 |
29+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 11 |
33+
34+
35+
Rollup of 6 pull requests [#115672](https://github.com/rust-lang/rust/pull/115672) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cd71a37f320c379df47ff64abd934f3a2da94c26&end=309af3442a1808888e3ceb2eacccbf4140eba1e0&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 4.2% | [0.8%, 9.8%] | 5 |
40+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 4.2% | [0.8%, 9.8%] | 5 |
44+
45+
46+
Use the same DISubprogram for each instance of the same inlined function within a caller [#115417](https://github.com/rust-lang/rust/pull/115417) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ffc48e3eda36e288f76b4022d72d94321887ebf5&end=62ebe3a2b177d50ec664798d731b8a8d1a9120d1&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 1.0% | [0.6%, 1.3%] | 3 |
51+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 1.0% | [0.6%, 1.3%] | 3 |
55+
56+
57+
#### Improvements
58+
59+
Span tweaks [#115594](https://github.com/rust-lang/rust/pull/115594) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=38bbc2ce03a2369d96898d58cc0aa06f1a4b5dcf&end=6cc1898f5f4f3ffec96ce2b7c3be723db558d470&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
66+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 6 |
67+
| All ❌✅ (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
68+
69+
70+
Disentangle `Debug` and `Display` for `Ty`. [#115661](https://github.com/rust-lang/rust/pull/115661) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e39976ff89f91b742916349859e8d877a4876783&end=7d1e416d3234bdfed6443dc2e4301f2d6f063525&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 4 |
77+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.5%, -0.2%] | 3 |
78+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.2%] | 4 |
79+
80+
81+
#### Mixed
82+
83+
Represent MIR composite debuginfo as projections instead of aggregates [#115252](https://github.com/rust-lang/rust/pull/115252) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a0c28cd9dc99d9acb015d06f6b27c640adad3550&end=a5b2ac6906d2b688db4938f842057cde6054449c&stat=instructions:u)
84+
85+
| (instructions:u) | mean | range | count |
86+
|:----------------------------------:|:-----:|:--------------:|:-----:|
87+
| Regressions ❌ <br /> (primary) | 3.9% | [3.9%, 3.9%] | 1 |
88+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
89+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
90+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.3%] | 4 |
91+
| All ❌✅ (primary) | 1.1% | [-0.3%, 3.9%] | 3 |
92+
93+
94+
Use a specialized varint + bitpacking scheme for DepGraph encoding [#110050](https://github.com/rust-lang/rust/pull/110050) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4e5b31c2b0023dba53a1b2827f4b7ac42aaaa18f&end=f00c1399987c60b4e884afc42f4aa6226855e9ae&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | - | - | 0 |
99+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 0.8%] | 4 |
100+
| Improvements ✅ <br /> (primary) | -1.7% | [-5.8%, -0.3%] | 104 |
101+
| Improvements ✅ <br /> (secondary) | -1.4% | [-2.9%, -0.5%] | 32 |
102+
| All ❌✅ (primary) | -1.7% | [-5.8%, -0.3%] | 104 |
103+
104+
105+
Rollup of 7 pull requests [#115665](https://github.com/rust-lang/rust/pull/115665) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3d249706aa8b0167dd49efa1b3ce7cc0e9cbba08&end=de4cba3a98a15a891ad708a049c7fb5682083d97&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | 0.7% | [0.6%, 0.7%] | 2 |
110+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.5%, 0.7%] | 5 |
111+
| Improvements ✅ <br /> (primary) | - | - | 0 |
112+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
113+
| All ❌✅ (primary) | 0.7% | [0.6%, 0.7%] | 2 |
114+
115+
116+
Avoid a `source_span` query when encoding Spans into query results [#115657](https://github.com/rust-lang/rust/pull/115657) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5ede9408945b46ab183dd228253297bdf62304f7&end=38bbc2ce03a2369d96898d58cc0aa06f1a4b5dcf&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.4%] | 2 |
121+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.4%, 1.0%] | 7 |
122+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 2 |
123+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.4%] | 4 |
124+
| All ❌✅ (primary) | -0.0% | [-0.4%, 0.4%] | 4 |
125+
126+
127+
Encode only MIR reachable from other crates [#115306](https://github.com/rust-lang/rust/pull/115306) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8e37c509fda1f7387895e33783cba94ea3960a29&end=7418413a7fad1c4e8b82f970bd78af030e5f813e&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | 0.8% | [0.3%, 2.4%] | 15 |
132+
| Regressions ❌ <br /> (secondary) | 1.9% | [0.3%, 9.1%] | 7 |
133+
| Improvements ✅ <br /> (primary) | -1.3% | [-2.7%, -0.4%] | 12 |
134+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.2%, -0.7%] | 5 |
135+
| All ❌✅ (primary) | -0.1% | [-2.7%, 2.4%] | 27 |
136+
137+
138+
#### Untriaged Pull Requests
139+
140+
- [#115665 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/115665)
141+
- [#115657 Avoid a `source_span` query when encoding Spans into query results](https://github.com/rust-lang/rust/pull/115657)
142+
- [#115401 Add `FreezeLock` type and use it to store `Definitions`](https://github.com/rust-lang/rust/pull/115401)
143+
- [#115306 Encode only MIR reachable from other crates](https://github.com/rust-lang/rust/pull/115306)
144+
- [#115252 Represent MIR composite debuginfo as projections instead of aggregates](https://github.com/rust-lang/rust/pull/115252)
145+
- [#115082 Fix races conditions with `SyntaxContext` decoding](https://github.com/rust-lang/rust/pull/115082)
146+
- [#114892 Remove conditional use of `Sharded` from query caches](https://github.com/rust-lang/rust/pull/114892)
147+
- [#114481 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/114481)
148+
- [#114459 Do not run ConstProp on mir_for_ctfe.](https://github.com/rust-lang/rust/pull/114459)
149+
- [#114321 get auto traits for parallel rustc](https://github.com/rust-lang/rust/pull/114321)
150+
- [#114023 Warn on inductive cycle in coherence leading to impls being considered not overlapping](https://github.com/rust-lang/rust/pull/114023)
151+
- [#114004 Add `riscv64gc-unknown-hermit` target](https://github.com/rust-lang/rust/pull/114004)
152+
- [#113858 Always const-prop scalars and scalar pairs](https://github.com/rust-lang/rust/pull/113858)
153+
- [#113758 Turn copy into moves during DSE.](https://github.com/rust-lang/rust/pull/113758)
154+
- [#113485 Bump version to 1.73](https://github.com/rust-lang/rust/pull/113485)
155+
- [#113370 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/113370)
156+
- [#113320 Add some extra information to opaque type cycle errors](https://github.com/rust-lang/rust/pull/113320)
157+
- [#113306 Update debuginfo test runner to provide more useful output](https://github.com/rust-lang/rust/pull/113306)
158+
- [#113304 Upgrade to indexmap 2.0.0](https://github.com/rust-lang/rust/pull/113304)
159+
- [#113270 perform TokenStream replacement in-place when possible in expand_macro](https://github.com/rust-lang/rust/pull/113270)
160+
- [#113057 Rollup of 2 pull requests](https://github.com/rust-lang/rust/pull/113057)
161+
- [#112963 Stop bubbling out hidden types from the eval obligation queries](https://github.com/rust-lang/rust/pull/112963)
162+
- [#112882 Rewrite `UnDerefer`](https://github.com/rust-lang/rust/pull/112882)
163+
- [#112420 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/112420)
164+
- [#112157 Resurrect: rustc_target: Add alignment to indirectly-passed by-value types, correcting the alignment of byval on x86 in the process.](https://github.com/rust-lang/rust/pull/112157)
165+
- [#112083 Make `TrustedStep` require `Copy`](https://github.com/rust-lang/rust/pull/112083)
166+
- [#112016 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/112016)
167+
- [#112001 Enable MatchBranchSimplification](https://github.com/rust-lang/rust/pull/112001)
168+
- [#111869 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/111869)
169+
- [#111850 Specialize `StepBy<Range<{integer}>>`](https://github.com/rust-lang/rust/pull/111850)
170+
171+
#### Nags requiring follow up
172+
173+
TODO: Nags
174+

0 commit comments

Comments
 (0)