Skip to content

Commit 104cd74

Browse files
committed
Revert "[clang-format] Handle object instansiation in if-statements"
This reverts commit 70de684. This causes a regression as described in rust-lang#61785
1 parent 62a0049 commit 104cd74

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

clang/lib/Format/TokenAnnotator.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -421,8 +421,7 @@ class AnnotatingParser {
421421
FormatToken *Next = CurrentToken->Next;
422422
if (PrevPrev && PrevPrev->is(tok::identifier) &&
423423
Prev->isOneOf(tok::star, tok::amp, tok::ampamp) &&
424-
CurrentToken->is(tok::identifier) &&
425-
!Next->isOneOf(tok::equal, tok::l_brace)) {
424+
CurrentToken->is(tok::identifier) && Next->isNot(tok::equal)) {
426425
Prev->setType(TT_BinaryOperator);
427426
LookForDecls = false;
428427
}
@@ -2517,12 +2516,6 @@ class AnnotatingParser {
25172516
return TT_PointerOrReference;
25182517
}
25192518

2520-
// if (Class* obj { function() })
2521-
if (PrevToken->Tok.isAnyIdentifier() && NextToken->Tok.isAnyIdentifier() &&
2522-
NextToken->Next && NextToken->Next->is(tok::l_brace)) {
2523-
return TT_PointerOrReference;
2524-
}
2525-
25262519
if (PrevToken->endsSequence(tok::r_square, tok::l_square, tok::kw_delete))
25272520
return TT_UnaryOperator;
25282521

clang/unittests/Format/TokenAnnotatorTest.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -146,18 +146,6 @@ TEST_F(TokenAnnotatorTest, UnderstandsUsesOfStarAndAmp) {
146146
EXPECT_TOKEN(Tokens[7], tok::star, TT_UnaryOperator);
147147
EXPECT_TOKEN(Tokens[12], tok::star, TT_PointerOrReference);
148148

149-
Tokens = annotate("if (Foo * Bar / Test)");
150-
ASSERT_EQ(Tokens.size(), 9u) << Tokens;
151-
EXPECT_TOKEN(Tokens[3], tok::star, TT_BinaryOperator);
152-
153-
Tokens = annotate("if (Class* obj {getObj()})");
154-
ASSERT_EQ(Tokens.size(), 12u) << Tokens;
155-
EXPECT_TOKEN(Tokens[3], tok::star, TT_PointerOrReference);
156-
157-
Tokens = annotate("if (Foo* Bar = getObj())");
158-
ASSERT_EQ(Tokens.size(), 11u) << Tokens;
159-
EXPECT_TOKEN(Tokens[3], tok::star, TT_PointerOrReference);
160-
161149
Tokens = annotate("int f3() { return sizeof(Foo&); }");
162150
ASSERT_EQ(Tokens.size(), 14u) << Tokens;
163151
EXPECT_TOKEN(Tokens[9], tok::amp, TT_PointerOrReference);

0 commit comments

Comments
 (0)