Skip to content

Commit 1607871

Browse files
committed
Add some FIXME for future Cargo issues
1 parent 385470b commit 1607871

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/bootstrap/bin/rustc.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,18 @@ fn main() {
115115

116116
// The compiler builtins are pretty sensitive to symbols referenced in
117117
// libcore and such, so we never compile them with debug assertions.
118+
//
119+
// FIXME(rust-lang/cargo#7253) we should be doing this in `builder.rs`
120+
// with env vars instead of doing it here in this script.
118121
if crate_name == Some("compiler_builtins") {
119122
cmd.arg("-C").arg("debug-assertions=no");
120123
} else {
121124
cmd.arg("-C").arg(format!("debug-assertions={}", debug_assertions));
122125
}
123126
} else {
127+
// FIXME(rust-lang/cargo#5754) we shouldn't be using special env vars
128+
// here, but rather Cargo should know what flags to pass rustc itself.
129+
124130
// Override linker if necessary.
125131
if let Ok(host_linker) = env::var("RUSTC_HOST_LINKER") {
126132
cmd.arg(format!("-Clinker={}", host_linker));

0 commit comments

Comments
 (0)