Skip to content

Commit 62e9026

Browse files
Rollup merge of rust-lang#143041 - Kobzol:matrix-no-cache, r=marcoieni
Remove cache for citool I'm not sure why, but after the citool cache is loaded, compiling just build_helper and citool takes ~30s, which is very slow. Combined with the fact that just loading the cache takes ~15s, and we have to run a hacky workflow on master, which results [in benign failures](https://github.com/rust-lang/rust/actions?query=branch%3Amaster), I don't think it's worth it to use the cache here anymore. A fresh build, now that we don't run citool tests on PR CI, takes just ~35-40s, so it's actually faster now *not* to cache. The trade-offs change quite often :) r? `@ghost`
2 parents 213e34d + 7960272 commit 62e9026

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@ name: CI
1111
on:
1212
push:
1313
branches:
14-
# CI on master only serves for caching citool builds for the `calculate_matrix` job.
15-
# In order to use GHA cache on PR CI (and auto/try) jobs, we need to write to it
16-
# from the default branch.
17-
- master
1814
- auto
1915
- try
2016
- try-perf
@@ -57,13 +53,6 @@ jobs:
5753
steps:
5854
- name: Checkout the source code
5955
uses: actions/checkout@v4
60-
# Cache citool to make its build faster, as it's in the critical path.
61-
# The rust-cache doesn't bleed into the main `job`, so it should not affect any other
62-
# Rust compilation.
63-
- name: Cache citool
64-
uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
65-
with:
66-
workspaces: src/ci/citool
6756
- name: Test citool
6857
# Only test citool on the auto branch, to reduce latency of the calculate matrix job
6958
# on PR/try builds.

0 commit comments

Comments
 (0)