CMake: change xcpp linkage scope to PRIVATE

p4vook · vgvassilev · commit f729eb76e6a5 · 2024-05-20T11:31:48.000+03:00
Previously the linkage was PUBLIC, which caused xcpp to link to the
already existing libxeus-clang-repl.so instead of the just built one.

Signed-off-by: Pavel Kalugin &lt;pavel@pavelthebest.me&gt;
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -214,7 +214,7 @@ set_target_properties(xcpp PROPERTIES
   ENABLE_EXPORTS 1
   CXX_STANDARD ${CMAKE_CXX_STANDARD}
 )
-target_link_libraries(xcpp PUBLIC xeus-clang-repl pthread Python::Python)
+target_link_libraries(xcpp PRIVATE xeus-clang-repl pthread Python::Python)
 
 #TODO: We may be need sse RPATH
 #set_target_properties(xcpp clangCppInterOp PROPERTIES

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ set_target_properties(xcpp PROPERTIES`
`214`	`214`	`ENABLE_EXPORTS 1`
`215`	`215`	`CXX_STANDARD ${CMAKE_CXX_STANDARD}`
`216`	`216`	`)`
`217`		`-target_link_libraries(xcpp PUBLIC xeus-clang-repl pthread Python::Python)`
	`217`	`+target_link_libraries(xcpp PRIVATE xeus-clang-repl pthread Python::Python)`
`218`	`218`
`219`	`219`	`#TODO: We may be need sse RPATH`
`220`	`220`	`#set_target_properties(xcpp clangCppInterOp PROPERTIES`