Treat all warnings as errors

Author: mcbarton

CMakeLists.txt

@@ -47,6 +47,8 @@ OPTION(XEUS_CPP_BUILD_EXECUTABLE "Build the xcpp executable" ON)
 OPTION(XEUS_CPP_USE_SHARED_XEUS "Link xcpp  with the xeus shared library (instead of the static library)" ON)
 OPTION(XEUS_CPP_USE_SHARED_XEUS_CPP "Link xcpp  with the xeus shared library (instead of the static library)" ON)
 
+option(CMAKE_COMPILE_WARNING_AS_ERROR "Compile warnings as errors" ON)
+
 # Test options
 OPTION(XEUS_CPP_BUILD_TESTS "xeus-cpp test suite" ON)
 OPTION(XEUS_CPP_ENABLE_CODE_COVERAGE "xeus-cpp test suite" OFF)

src/xinterpreter.cpp

@@ -101,7 +101,7 @@ int __get_cxx_version () {
 __get_cxx_version ()
       )";
 
-      long cxx_version = Cpp::Evaluate(code);
+      auto cxx_version = Cpp::Evaluate(code);
       return std::to_string(cxx_version);
     }
 
@@ -133,7 +133,6 @@ __get_cxx_version ()
         bool silent,
         bool /*store_history*/,
         nl::json /*user_expressions*/,
-        bool allow_stdin
     )
     {
         nl::json kernel_res;