Skip to content

cleaning redundant code #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

notanaveragelifter
Copy link

What I Did

  • Removed the redundant block in createInterpreter that handled the -resource-dir flag, as this logic is already handled in cppinterop.
  • Added Emscripten-specific handling to ensure the -resource-dir flag is correctly set to /include for JupyterLite environments.

Why This Is Needed

  • The redundant block caused unnecessary duplication and potential logical errors.
  • The Emscripten build previously used incorrect paths for the resource directory, which is now fixed.

Testing

  • Verified that the -resource-dir flag is correctly handled in both native and Emscripten builds.

@anutosh491
Copy link
Collaborator

Thanks for opening a PR but we wouldn't need to handle emscripten specific stuff separately now as #290 gets rid of all hardcoding for for the emscripten build (which means even something like resource dir would be addressed similarly for both native and wasm kernels)

@anutosh491 anutosh491 closed this May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants