Skip to content

Commit fc881b2

Browse files
committed
[SourceKit] Expose all refactoring actions as requests in sourcekitd-test
1 parent b0bade6 commit fc881b2

File tree

10 files changed

+61
-26
lines changed

10 files changed

+61
-26
lines changed

test/SourceKit/Refactoring/semantic-refactoring/expand-default.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ func foo(e : E) {
1010
}
1111

1212
// RUN: %empty-directory(%t.result)
13-
// RUN: %sourcekitd-test -req=expand-default -pos=7:7 %s -- %s > %t.result/expand-default.swift.expected
13+
// RUN: %sourcekitd-test -req=refactoring.expand.default -pos=7:7 %s -- %s > %t.result/expand-default.swift.expected
1414
// RUN: %diff -u %S/expand-default.swift.expected %t.result/expand-default.swift.expected
1515

1616
// REQUIRES: OS=macosx || OS=linux-gnu

test/SourceKit/Refactoring/semantic-refactoring/extract-func-default.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ func foo() -> Int {
55
}
66

77
// RUN: %empty-directory(%t.result)
8-
// RUN: %sourcekitd-test -req=extract-func -pos=2:1 -end-pos 4:11 %s -- %s > %t.result/extract-func-default.swift.expected
8+
// RUN: %sourcekitd-test -req=refactoring.extract.function -pos=2:1 -end-pos 4:11 %s -- %s > %t.result/extract-func-default.swift.expected
99
// RUN: %diff -u %S/extract-func-default.swift.expected %t.result/extract-func-default.swift.expected
1010

1111
// FIXME: Fails on linux with assertion: "!GlibcModuleMapPath.empty()"" failed

test/SourceKit/Refactoring/semantic-refactoring/extract-func-with-args.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ func foo() -> Int {
55
}
66

77
// RUN: %empty-directory(%t.result)
8-
// RUN: %sourcekitd-test -req=extract-func -pos=3:1 -end-pos 3:12 -name new_name %s -- %s > %t.result/extract-func-with-args.swift.expected
8+
// RUN: %sourcekitd-test -req=refactoring.extract.function -pos=3:1 -end-pos 3:12 -name new_name %s -- %s > %t.result/extract-func-with-args.swift.expected
99
// RUN: %diff -u %S/extract-func-with-args.swift.expected %t.result/extract-func-with-args.swift.expected
1010

1111
// FIXME: Fails on linux with assertion: "!GlibcModuleMapPath.empty()"" failed

test/SourceKit/Refactoring/semantic-refactoring/extract-func.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ func foo() -> Int {
55
}
66

77
// RUN: %empty-directory(%t.result)
8-
// RUN: %sourcekitd-test -req=extract-func -pos=2:1 -end-pos 4:11 -name new_name %s -- %s > %t.result/extract-func.swift.expected
8+
// RUN: %sourcekitd-test -req=refactoring.extract.function -pos=2:1 -end-pos 4:11 -name new_name %s -- %s > %t.result/extract-func.swift.expected
99
// RUN: %diff -u %S/extract-func.swift.expected %t.result/extract-func.swift.expected
1010

1111
// FIXME: Fails on linux with assertion: "!GlibcModuleMapPath.empty()"" failed

test/SourceKit/Refactoring/semantic-refactoring/extract-repeated-expression.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ func foo() -> Int {
55
}
66

77
// RUN: %empty-directory(%t.result)
8-
// RUN: %sourcekitd-test -req=extract-repeated -pos=3:11 -end-pos 3:12 -name new_name %s -- %s > %t.result/extract-repeated-expression.swift.expected
8+
// RUN: %sourcekitd-test -req=refactoring.extract.expr.repeated -pos=3:11 -end-pos 3:12 -name new_name %s -- %s > %t.result/extract-repeated-expression.swift.expected
99
// RUN: %diff -u %S/extract-repeated-expression.swift.expected %t.result/extract-repeated-expression.swift.expected
1010

1111
// REQUIRES: OS=macosx || OS=linux-gnu

test/SourceKit/Refactoring/semantic-refactoring/fill-stub.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ protocol P {
55
class C1 : P {}
66

77
// RUN: %empty-directory(%t.result)
8-
// RUN: %sourcekitd-test -req=fill-stub -pos=5:8 %s -- %s > %t.result/fill-stub.swift.expected
8+
// RUN: %sourcekitd-test -req=refactoring.fillstub -pos=5:8 %s -- %s > %t.result/fill-stub.swift.expected
99
// RUN: %diff -u %S/fill-stub.swift.expected %t.result/fill-stub.swift.expected
1010

1111
// REQUIRES: OS=macosx || OS=linux-gnu
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %sourcekitd-test -req=local-rename -pos=4:7 -name new_name %s -- %s
1+
// RUN: %sourcekitd-test -req=refactoring.rename.local -pos=4:7 -name new_name %s -- %s
22

33
var Foo: Int {
4-
var missingNewlineAtEndOfFile
4+
var missingNewlineAtEndOfFile

test/SourceKit/Refactoring/semantic-refactoring/local-rename.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ func foo() {
1212
}
1313

1414
// RUN: %empty-directory(%t.result)
15-
// RUN: %sourcekitd-test -req=local-rename -pos=2:8 -name new_name %s -- %s > %t.result/local-rename.swift.expected
15+
// RUN: %sourcekitd-test -req=refactoring.rename.local -pos=2:8 -name new_name %s -- %s > %t.result/local-rename.swift.expected
1616
// RUN: %diff -u %S/local-rename.swift.expected %t.result/local-rename.swift.expected
1717
// RUN: %sourcekitd-test -req=find-local-rename-ranges -pos=2:8 %s -- %s > %t.result/local-rename-ranges.swift.expected
1818
// RUN: %diff -u %S/local-rename-ranges.swift.expected %t.result/local-rename-ranges.swift.expected

test/SourceKit/Refactoring/semantic-refactoring/localize-string.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: OS=macosx || OS=linux-gnu
22

33
func foo() -> String {
4-
// RUN: %sourcekitd-test -req=localize-string -pos=%(line+1):10 %s -- %s | %FileCheck %s --check-prefix=CHECK-BASIC
4+
// RUN: %sourcekitd-test -req=refactoring.localize.string -pos=%(line+1):10 %s -- %s | %FileCheck %s --check-prefix=CHECK-BASIC
55
return "abc"
66
// CHECK-BASIC: source.edit.kind.active:
77
// CHECK-BASIC: [[# @LINE-2]]:10-[[# @LINE-2]]:10 "NSLocalizedString("
@@ -11,7 +11,7 @@ func foo() -> String {
1111

1212
#sourceLocation(file: "someFile.swift", line: 20)
1313
func bar() -> String {
14-
// RUN: %sourcekitd-test -req=localize-string -pos=%(line+1):10 %s -- %s | %FileCheck %s --check-prefix=CHECK-DIRECTIVE
14+
// RUN: %sourcekitd-test -req=refactoring.localize.string -pos=%(line+1):10 %s -- %s | %FileCheck %s --check-prefix=CHECK-DIRECTIVE
1515
return "abc"
1616
// CHECK-DIRECTIVE: [[# @LINE-1]]:10-[[# @LINE-1]]:10
1717
}

tools/SourceKit/tools/sourcekitd-test/TestOptions.cpp

Lines changed: 50 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -143,31 +143,66 @@ bool TestOptions::parseArgs(llvm::ArrayRef<const char *> Args) {
143143
.Case("find-rename-ranges", SourceKitRequest::FindRenameRanges)
144144
.Case("find-local-rename-ranges", SourceKitRequest::FindLocalRenameRanges)
145145
.Case("translate", SourceKitRequest::NameTranslation)
146-
.Case("local-rename", SourceKitRequest::LocalRename)
147-
.Case("extract-expr", SourceKitRequest::ExtractExpr)
148-
.Case("extract-repeated", SourceKitRequest::ExtractRepeatedExpr)
149-
.Case("extract-func", SourceKitRequest::ExtractFunction)
150-
.Case("fill-stub", SourceKitRequest::FillProtocolStub)
151-
.Case("expand-default", SourceKitRequest::ExpandDefault)
152-
.Case("localize-string", SourceKitRequest::LocalizeString)
153146
.Case("markup-xml", SourceKitRequest::MarkupToXML)
154147
.Case("stats", SourceKitRequest::Statistics)
155148
.Case("track-compiles", SourceKitRequest::EnableCompileNotifications)
156149
.Case("collect-type", SourceKitRequest::CollectExpresstionType)
157150
.Case("global-config", SourceKitRequest::GlobalConfiguration)
158151
.Case("dependency-updated", SourceKitRequest::DependencyUpdated)
152+
#define SEMANTIC_REFACTORING(KIND, NAME, ID) .Case("refactoring." #ID, SourceKitRequest::KIND)
153+
#include "swift/IDE/RefactoringKinds.def"
159154
.Default(SourceKitRequest::None);
160155

161156
if (Request == SourceKitRequest::None) {
162157
llvm::errs() << "error: invalid request '" << InputArg->getValue()
163-
<< "'\nexpected one of "
164-
<< "version/demangle/mangle/index/complete/complete.open/complete.cursor/"
165-
"complete.update/complete.cache.ondisk/complete.cache.setpopularapi/"
166-
"cursor/related-idents/syntax-map/structure/format/expand-placeholder/"
167-
"doc-info/sema/interface-gen/interface-gen-openfind-usr/find-interface/"
168-
"open/close/edit/print-annotations/print-diags/extract-comment/module-groups/"
169-
"range/syntactic-rename/find-rename-ranges/translate/markup-xml/stats/"
170-
"track-compiles/collect-type\n";
158+
<< "'\nexpected one of "
159+
<< "- version\n"
160+
<< "- compiler-version\n"
161+
<< "- demangle\n"
162+
<< "- mangle\n"
163+
<< "- index\n"
164+
<< "- complete\n"
165+
<< "- complete.open\n"
166+
<< "- complete.close\n"
167+
<< "- complete.update\n"
168+
<< "- complete.cache.ondisk\n"
169+
<< "- complete.setpopularapi\n"
170+
<< "- typecontextinfo\n"
171+
<< "- conformingmethods\n"
172+
<< "- cursor\n"
173+
<< "- related-idents\n"
174+
<< "- syntax-map\n"
175+
<< "- syntax-tree\n"
176+
<< "- structure\n"
177+
<< "- format\n"
178+
<< "- expand-placeholder\n"
179+
<< "- doc-info\n"
180+
<< "- sema\n"
181+
<< "- interface-gen\n"
182+
<< "- interface-gen-open\n"
183+
<< "- find-usr\n"
184+
<< "- find-interface\n"
185+
<< "- open\n"
186+
<< "- close\n"
187+
<< "- edit\n"
188+
<< "- print-annotations\n"
189+
<< "- print-diags\n"
190+
<< "- extract-comment\n"
191+
<< "- module-groups\n"
192+
<< "- range\n"
193+
<< "- syntactic-rename\n"
194+
<< "- find-rename-ranges\n"
195+
<< "- find-local-rename-ranges\n"
196+
<< "- translate\n"
197+
<< "- markup-xml\n"
198+
<< "- stats\n"
199+
<< "- track-compiles\n"
200+
<< "- collect-type\n"
201+
<< "- global-config\n"
202+
<< "- dependency-updated\n"
203+
#define SEMANTIC_REFACTORING(KIND, NAME, ID) << "- refactoring." #ID "\n"
204+
#include "swift/IDE/RefactoringKinds.def"
205+
"\n";
171206
return true;
172207
}
173208
break;

0 commit comments

Comments
 (0)