handle calls to unresolved member methods

Author: andrurogerz

Sources/idt/idt.cc

@@ -514,6 +514,19 @@ class visitor : public clang::RecursiveASTVisitor<visitor> {
     return true;
   }
 
+  // Visit every unresolved member expression in the compilation unit to
+  // determine if there are overloaded private methods that might be called. In
+  // this uncommon case, the private method should be annotated.
+  bool VisitUnresolvedMemberExpr(clang::UnresolvedMemberExpr *E) {
+    // Iterate over potential declarations
+    for (const clang::NamedDecl *ND : E->decls())
+      if (const auto *MD = llvm::dyn_cast<clang::CXXMethodDecl>(ND))
+        if (MD->getAccess() == clang::AccessSpecifier::AS_private)
+          export_function_if_needed(MD);
+
+    return true;
+  }
+
   // Visit every constructor call in the compilation unit to determine if there
   // are any inline calls to private constructors. In this uncommon case, the
   // private constructor must be annotated for export. Constructor calls are not

Tests/TemplateCallsPrivateMethod.hh

@@ -0,0 +1,20 @@
+// RUN: %idt --export-macro IDT_TEST_ABI %s 2>&1 | %FileCheck %s
+
+class TemplateCallsPrivateMethod {
+public:
+  // CHECK-NOT: TemplateCallsPrvateMethod.hh:[[@LINE+1]]:{{.*}}
+  template <typename T> void publicTemplateMethod(T x) {
+    privateMethodForTemplate(x);
+  }
+
+private:
+  // NOTE: we use CHECK-DAG here because these remarks may come out of order and
+  // we cannot control the order by rearranging members.
+
+  // CHECK-DAG: TemplateCallsPrivateMethod.hh:[[@LINE+1]]:3: remark: unexported public interface 'privateMethodForTemplate'
+  void privateMethodForTemplate(long x) const;
+
+  // CHECK-DAG: TemplateCallsPrivateMethod.hh:[[@LINE+1]]:3: remark: unexported public interface 'privateMethodForTemplate'
+  void privateMethodForTemplate(int x) const;
+};
+