Skip to content

Commit d558028

Browse files
committed
GHA: enable HCS on Windows toolchains
Now that the just built clang should no longer perform HCS on scoped EH functions, we should be able to enable this optimization globally.
1 parent 0cc87ce commit d558028

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/swift-toolchain.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2585,10 +2585,10 @@ jobs:
25852585
-D CMAKE_BUILD_TYPE=Release `
25862586
-D CMAKE_C_COMPILER=${CLANG_CL} `
25872587
-D CMAKE_C_COMPILER_TARGET=${{ matrix.triple }} `
2588-
-D CMAKE_C_FLAGS="${{ inputs.WINDOWS_CMAKE_C_FLAGS }} -Xclang -fno-split-cold-code" `
2588+
-D CMAKE_C_FLAGS="${{ inputs.WINDOWS_CMAKE_C_FLAGS }}" `
25892589
-D CMAKE_CXX_COMPILER=${CLANG_CL} `
25902590
-D CMAKE_CXX_COMPILER_TARGET=${{ matrix.triple }} `
2591-
-D CMAKE_CXX_FLAGS="${{ inputs.WINDOWS_CMAKE_CXX_FLAGS }} -Xclang -fno-split-cold-code -I ${{ github.workspace }}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr/include -I ${{ github.workspace }}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr/include/Block" `
2591+
-D CMAKE_CXX_FLAGS="${{ inputs.WINDOWS_CMAKE_CXX_FLAGS }} -I ${{ github.workspace }}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr/include -I ${{ github.workspace }}/BuildRoot/Library/Developer/Platforms/Windows.platform/Developer/SDKs/Windows.sdk/usr/include/Block" `
25922592
-D CMAKE_MT=mt `
25932593
-D CMAKE_INSTALL_PREFIX=${{ github.workspace }}/BuildRoot-DevTools/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr `
25942594
-D CMAKE_Swift_COMPILER=${SWIFTC} `
@@ -2615,10 +2615,10 @@ jobs:
26152615
-D CMAKE_BUILD_TYPE=Release `
26162616
-D CMAKE_C_COMPILER=${CLANG_CL} `
26172617
-D CMAKE_C_COMPILER_TARGET=${{ matrix.triple }} `
2618-
-D CMAKE_C_FLAGS="${{ inputs.WINDOWS_CMAKE_C_FLAGS }} -Xclang -fno-split-cold-code" `
2618+
-D CMAKE_C_FLAGS="${{ inputs.WINDOWS_CMAKE_C_FLAGS }}" `
26192619
-D CMAKE_CXX_COMPILER=${CLANG_CL} `
26202620
-D CMAKE_CXX_COMPILER_TARGET=${{ matrix.triple }} `
2621-
-D CMAKE_CXX_FLAGS="${{ inputs.WINDOWS_CMAKE_CXX_FLAGS }} -Xclang -fno-split-cold-code" `
2621+
-D CMAKE_CXX_FLAGS="${{ inputs.WINDOWS_CMAKE_CXX_FLAGS }}" `
26222622
-D CMAKE_MT=mt `
26232623
-D CMAKE_INSTALL_PREFIX=${{ github.workspace }}/BuildRoot-DevTools/Library/Developer/Toolchains/unknown-Asserts-development.xctoolchain/usr `
26242624
-D CMAKE_Swift_COMPILER=${SWIFTC} `

0 commit comments

Comments
 (0)