Skip to content

Commit dd473f2

Browse files
committed
Include the SwiftSyntaxCDataType.h from 5.6 onward
Add the necessary plumbing via HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER Ensure that this flag is set for the releases 5.6 onwards
1 parent b896992 commit dd473f2

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

.ci/templates/toolchain-msi.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,19 +78,26 @@ jobs:
7878
solution: $(Build.SourcesDirectory)/wix/windows-toolchain.wixproj
7979
msbuildArguments: /p:RunWixToolsOutOfProc=true -p:OutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:IntermediateOutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:TOOLCHAIN_ROOT=$(toolchain.directory) -p:INCLUDE_LLDB_PYTHON_SCRIPTS=true
8080

81-
- ${{ if or(eq(parameters.VERSION, '5.5'), eq(parameters.VERSION, '5.6')) }}:
81+
- ${{ if eq(parameters.VERSION, '5.5') }}:
8282
- task: MSBuild@1
8383
displayName: toolchain.msi
8484
inputs:
8585
solution: $(Build.SourcesDirectory)/wix/windows-toolchain.wixproj
8686
msbuildArguments: /p:RunWixToolsOutOfProc=true -p:OutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:IntermediateOutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:TOOLCHAIN_ROOT=$(toolchain.directory) -p:INCLUDE_LLDB_PYTHON_SCRIPTS=true -p:HAVE__INTERNAL_SWIFT_SYNTAX_PARSER=true -p:HAVE__INTERNAL_SWIFT_SCAN=true
8787

88+
- ${{ if eq(parameters.VERSION, '5.6') }}:
89+
- task: MSBuild@1
90+
displayName: toolchain.msi
91+
inputs:
92+
solution: $(Build.SourcesDirectory)/wix/windows-toolchain.wixproj
93+
msbuildArguments: /p:RunWixToolsOutOfProc=true -p:OutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:IntermediateOutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:TOOLCHAIN_ROOT=$(toolchain.directory) -p:INCLUDE_LLDB_PYTHON_SCRIPTS=true -p:HAVE__INTERNAL_SWIFT_SYNTAX_PARSER=true -p:HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER=true -p:HAVE__INTERNAL_SWIFT_SCAN=true
94+
8895
- ${{ if and(ne(parameters.VERSION, '5.2'), ne(parameters.VERSION, '5.3'), ne(parameters.VERSION, '5.4'), ne(parameters.VERSION, '5.5'), ne(parameters.VERSION, '5.6')) }}:
8996
- task: MSBuild@1
9097
displayName: toolchain.msi
9198
inputs:
9299
solution: $(Build.SourcesDirectory)/wix/windows-toolchain.wixproj
93-
msbuildArguments: /p:RunWixToolsOutOfProc=true -p:OutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:IntermediateOutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:DEVTOOLS_ROOT=$(devtools.directory) -p:TOOLCHAIN_ROOT=$(toolchain.directory) -p:INCLUDE_LLDB_PYTHON_SCRIPTS=true -p:HAVE__INTERNAL_SWIFT_SYNTAX_PARSER=true -p:HAVE__INTERNAL_SWIFT_SCAN=true -p:ENABLE_SWIFT_DRIVER=true
100+
msbuildArguments: /p:RunWixToolsOutOfProc=true -p:OutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:IntermediateOutputPath=$(Build.BinariesDirectory)\toolchain-msi\ -p:DEVTOOLS_ROOT=$(devtools.directory) -p:TOOLCHAIN_ROOT=$(toolchain.directory) -p:INCLUDE_LLDB_PYTHON_SCRIPTS=true -p:HAVE__INTERNAL_SWIFT_SYNTAX_PARSER=true -p:HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER=true -p:HAVE__INTERNAL_SWIFT_SCAN=true -p:ENABLE_SWIFT_DRIVER=true
94101

95102
- script: |
96103
signtool sign /f $(certificate.secureFilePath) /p "$(CERTIFICATE_PASSWORD)" /tr http://timestamp.digicert.com /fd sha256 /td sha256 $(Build.BinariesDirectory)/toolchain-msi/toolchain.msi

wix/windows-toolchain.wixproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
<INCLUDE_LLDB_PYTHON_SCRIPTS Condition=" '$(INCLUDE_LLDB_PYTHON_SCRIPTS)' == '' ">true</INCLUDE_LLDB_PYTHON_SCRIPTS>
2929
<HAVE__INTERNAL_SWIFT_SCAN Condition=" '$(HAVE__INTERNAL_SWIFT_SCAN)' == '' ">false</HAVE__INTERNAL_SWIFT_SCAN>
3030
<HAVE__INTERNAL_SWIFT_SYNTAX_PARSER Condition=" '$(HAVE__INTERNAL_SWIFT_SYNTAX_PARSER)' == '' ">false</HAVE__INTERNAL_SWIFT_SYNTAX_PARSER>
31+
<HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER Condition=" '$(HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER)' == '' ">false</HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER>
3132
<ENABLE_SWIFT_DRIVER Condition=" '$(ENABLE_SWIFT_DRIVER)' == '' ">false</ENABLE_SWIFT_DRIVER>
3233
</PropertyGroup>
3334

wix/windows-toolchain.wxs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,9 @@
395395
<DirectoryRef Id="USR_INCLUDE__INTERNALSWIFTSYNTAXPARSER">
396396
<?if $(var.HAVE__INTERNAL_SWIFT_SYNTAX_PARSER) = true ?>
397397
<Component Id="_INTERNALSWIFTSYNTAXPARSER_HEADERS" Guid="751f758a-ee88-4be5-9285-97bbf3aa374a">
398-
<File Id="SWIFTSYNTAXCDATATYPES_H" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\swift\_InternalSwiftSyntaxParser\SwiftSyntaxCDataTypes.h" Checksum="yes" />
398+
<?if $(var.HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER) = true ?>
399+
<File Id="SWIFTSYNTAXCDATATYPES_H" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\swift\_InternalSwiftSyntaxParser\SwiftSyntaxCDataTypes.h" Checksum="yes" />
400+
<?endif?>
399401
<File Id="SWIFTSYNTAXPARSER_H" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\swift\_InternalSwiftSyntaxParser\SwiftSyntaxParser.h" Checksum="yes" />
400402
<File Id="_INTERNALSWIFTSYNTAXPARSER_MODULE_MODULEMAP" Source="$(var.TOOLCHAIN_ROOT)\usr\lib\swift\_InternalSwiftSyntaxParser\module.modulemap" Checksum="yes" />
401403
</Component>

0 commit comments

Comments
 (0)