Skip to content

Commit 886ae88

Browse files
committed
refactor: SidebarToggler, AsideToggler
- add `defaultOpen` prop - add toggle `force` param - cleanup - fixes `SidebarToggler` toggling on `mount` issue
1 parent 19a0e66 commit 886ae88

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

src/components/Aside/AsideToggler.vue

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,35 +16,34 @@ import toggleClasses from '../../shared/toggle-classes'
1616
export default {
1717
name: 'AsideToggler',
1818
props: {
19-
mobile: {
19+
defaultOpen: {
2020
type: Boolean,
2121
default: false
2222
},
2323
display: {
2424
type: String,
2525
default: ''
26-
}
26+
},
27+
mobile: {
28+
type: Boolean,
29+
default: false
30+
},
2731
},
2832
computed: {
2933
classList () {
3034
return [
3135
'navbar-toggler'
32-
// 'd-none',
33-
// 'd-lg-inline-block'
3436
]
3537
}
3638
},
37-
mounted: function () {
38-
// this.toggle()
39-
},
4039
methods: {
41-
toggle () {
40+
toggle (force) {
4241
const [display, mobile] = [this.display, this.mobile]
4342
let cssClass = asideMenuCssClasses[0]
4443
if (!mobile && display && checkBreakpoint(display, validBreakpoints)) {
4544
cssClass = `aside-menu-${display}-show`
4645
}
47-
toggleClasses(cssClass, asideMenuCssClasses)
46+
toggleClasses(cssClass, asideMenuCssClasses, force)
4847
},
4948
asideToggle (e) {
5049
e.preventDefault()

src/components/Sidebar/SidebarToggler.vue

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,35 +16,37 @@ import toggleClasses from '../../shared/toggle-classes'
1616
export default {
1717
name: 'SidebarToggler',
1818
props: {
19-
mobile: {
19+
defaultOpen: {
2020
type: Boolean,
21-
default: false
21+
default: true
2222
},
2323
display: {
2424
type: String,
2525
default: 'lg'
26+
},
27+
mobile: {
28+
type: Boolean,
29+
default: false
2630
}
2731
},
2832
computed: {
2933
classList () {
3034
return [
3135
'navbar-toggler'
32-
// 'd-none',
33-
// 'd-lg-inline-block'
3436
]
3537
}
3638
},
3739
mounted: function () {
38-
this.toggle()
40+
this.toggle(this.defaultOpen)
3941
},
4042
methods: {
41-
toggle () {
43+
toggle (force) {
4244
const [display, mobile] = [this.display, this.mobile]
4345
let cssClass = sidebarCssClasses[0]
4446
if (!mobile && display && checkBreakpoint(display, validBreakpoints)) {
4547
cssClass = `sidebar-${display}-show`
4648
}
47-
toggleClasses(cssClass, sidebarCssClasses)
49+
toggleClasses(cssClass, sidebarCssClasses, force)
4850
},
4951
sidebarToggle (e) {
5052
e.preventDefault()

0 commit comments

Comments
 (0)