Skip to content

Remove cluster up/configure prompts #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 8, 2021
Merged

Remove cluster up/configure prompts #1936

merged 15 commits into from
Mar 8, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Mar 4, 2021 •
edited
Loading

checklist:

  • run make test and make lint
  • test manually: cluster(-gcp) up/info/delete. cluster configure fails.

@RobertLucian RobertLucian requested a review from vishalbollu March 4, 2021 21:29
vishalbollu
vishalbollu reviewed Mar 5, 2021
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like a docs pass has been made in the PR. I would search for --config and cortex cluster * commands and where the docs need to be modified.

vishalbollu
vishalbollu approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should required field as intended as opposed to minLength: 1.

vishalbollu
vishalbollu reviewed Mar 8, 2021
View reviewed changes
vishalbollu
vishalbollu reviewed Mar 8, 2021
View reviewed changes
@RobertLucian RobertLucian merged commit 625ddcd into master Mar 8, 2021
@RobertLucian RobertLucian deleted the cleanup/rm-cluster-prompts branch March 8, 2021 21:16
@vishalbollu vishalbollu added this to the 0.31 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.31
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @vishalbollu