Skip to content

Commit 65137de

Browse files
committed
RCBC-504: Update core and version generation
1 parent 044bd59 commit 65137de

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

ext/CMakeLists.txt

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,14 @@ add_library(
6161
rcb_version.cxx
6262
rcb_views.cxx)
6363
target_include_directories(couchbase PRIVATE ${PROJECT_BINARY_DIR}/generated)
64-
target_include_directories(couchbase PRIVATE SYSTEM ${RUBY_INCLUDE_DIR}
65-
${PROJECT_SOURCE_DIR}/couchbase
66-
${PROJECT_BINARY_DIR}/couchbase/generated
67-
${PROJECT_SOURCE_DIR}/couchbase/third_party/cxx_function
68-
${PROJECT_SOURCE_DIR}/couchbase/third_party/expected/include)
64+
target_include_directories(
65+
couchbase
66+
PRIVATE SYSTEM
67+
${RUBY_INCLUDE_DIR}
68+
${PROJECT_SOURCE_DIR}/couchbase
69+
${PROJECT_BINARY_DIR}/couchbase/generated
70+
${PROJECT_SOURCE_DIR}/couchbase/third_party/cxx_function
71+
${PROJECT_SOURCE_DIR}/couchbase/third_party/expected/include)
6972
target_link_libraries(
7073
couchbase
7174
PRIVATE project_options

ext/couchbase

ext/extconf.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ def sys(*cmd)
104104
elsif ENV["CB_STATIC_OPENSSL"]
105105
cmake_flags << "-DCOUCHBASE_CXX_CLIENT_STATIC_OPENSSL=ON"
106106
end
107+
cmake_flags << "-DCOUCHBASE_CXX_CLIENT_WRAPPER_UNIFIED_ID=ruby/#{Couchbase::VERSION[:sdk]}"
107108

108109
unless cmake_flags.grep(/BORINGSSL/)
109110
case RbConfig::CONFIG["target_os"]

ext/rcb_analytics.cxx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -911,17 +911,17 @@ cb_Backend_analytics_link_get_all(VALUE self, VALUE options)
911911
cb_throw_error(
912912
resp.ctx,
913913
fmt::format(R"(unable to retrieve links type={}, dataverse="{}", name="{}")",
914-
req.link_type,
915-
req.link_name,
916-
req.dataverse_name));
914+
req.link_type.value_or("-"),
915+
req.link_name.value_or("-"),
916+
req.dataverse_name.value_or("-")));
917917
} else {
918918
const auto& first_error = resp.errors.front();
919919
cb_throw_error(
920920
resp.ctx,
921921
fmt::format(R"(unable to retrieve links type={}, dataverse="{}", name="{}" ({}: {}))",
922-
req.link_type,
923-
req.link_name,
924-
req.dataverse_name,
922+
req.link_type.value_or("-"),
923+
req.link_name.value_or("-"),
924+
req.dataverse_name.value_or("-"),
925925
first_error.code,
926926
first_error.message));
927927
}

0 commit comments

Comments
 (0)