Skip to content

P1690R1 Refinement Proposal for P0919 Heterogeneous lookup for unordered containers #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

zygoloid
Copy link
Member

@zygoloid zygoloid commented Nov 13, 2019

Fixes #3406.

Also fixes NB US 235, US 236, PL 237, and US 238 (C++20 CD).

Fixes cplusplus/nbballot#232
Fixes cplusplus/nbballot#233
Fixes cplusplus/nbballot#234

Fixes cplusplus/papers#467

@jensmaurer jensmaurer added this to the post-2019-11 milestone Nov 13, 2019
@jensmaurer
Copy link
Member

@zygoloid , please fix the commit comment. "US 278" doesn't exist. You probably mean "US 238". Yes, that's also wrong on the straw polls page.

@zygoloid zygoloid force-pushed the motions-2019-11-lwg-3 branch from 51b3195 to 32430c2 Compare November 14, 2019 00:10
@zygoloid
Copy link
Member Author

zygoloid commented Nov 14, 2019

NB comment number fixed in commit message, in #2306, and here in #3445. I also sorted the NB comments into numerical order.

@zygoloid zygoloid force-pushed the motions-2019-11-lwg-3 branch from 32430c2 to 21753d6 Compare November 14, 2019 00:12
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

…red containers

Also fixes NB US 235, US 236, PL 237, and US 238 (C++20 CD).
@zygoloid zygoloid force-pushed the motions-2019-11-lwg-3 branch from 21753d6 to 5471093 Compare November 21, 2019 01:00
@zygoloid zygoloid merged commit 707c922 into master Nov 21, 2019
@jensmaurer jensmaurer deleted the motions-2019-11-lwg-3 branch February 18, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment