Skip to content

2022-11 LWG Motion 14 #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

2022-11 LWG Motion 14 #5978

merged 1 commit into from
Dec 15, 2022

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Nov 16, 2022

P2696R0 Introduce Cpp17Swappable as additional convenience requirements

Fixes #5975.
Also fixes #5627.
Also fixes #5628.
Fixes cplusplus/papers#1386.

@Dani-Hub
Copy link
Member

What kind of thing is "\oldconcept{Swap\-pable}"? (I'm asking about the intermediate "\-")

@tkoeppe tkoeppe force-pushed the motions-2022-11-lwg-14 branch from 48f7775 to 20d53aa Compare November 16, 2022 18:59
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 16, 2022

@Dani-Hub That's a hyphenation hint.

@Dani-Hub
Copy link
Member

Thanks for the explanation @tkoeppe !

Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also resolves #5627. From the paper:

[Drafting note: The suggested changes for p37 and p41 provide an alternative resolution for editorial issue 5627]

@Dani-Hub
Copy link
Member

@JohelEGP @tkoeppe This paper should also resolve #5628, unfortunately, I forgot to mention this in the paper (But #5628 refers to the paper, so there exists a connection).

@jwakely
Copy link
Member

jwakely commented Dec 9, 2022

It confused me that the edits for [container.reqmts] p37 and p41 are actually for [sequence.reqmts], sorry for not catching that in LWG.

Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of editorial comments, but this is a correct application of the approved changes.

Editorial notes:
* Added a cross-reference to [swappable.requirements] in
  [optional.swap].
* This change overwrites two earlier editorial improvements of the
  "swappable" wording from a7f1718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment