Skip to content

[support.initlist] Teletype font for initializer_list #6680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

Quuxplusone
Copy link
Contributor

This note is talking about the class type, not the grammatical construct, so it should say initializer_list.

Quuxplusone added a commit to Quuxplusone/draft that referenced this pull request Nov 13, 2023
The removed editorial-nit is now
cplusplus#6680
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 13, 2023

I'm looking for a better commit description. We're not just changing the font (like if it was a missing \tcode), but we're changing an english description of something to an actual type.

It's the kind of change that I would list in the editors' report, unlike a missing \tcode.

@JohelEGP
Copy link
Contributor

"Be more precise about what is copied".

@Quuxplusone
Copy link
Contributor Author

@tkoeppe: You mean for the top line of the git commit? I think the following two lines are if anything too explanatory. :)
How about [support.initlist] "initializer list" (syntax construct) should be "initializer_list" (class type)?
Also, please let me know whether you're waiting for me to reupload a new commit, or if you're fine with editing the commit message yourself. (I don't mind.)

Quuxplusone added a commit to Quuxplusone/draft that referenced this pull request Feb 7, 2024
The removed editorial-nit is now
cplusplus#6680
@Quuxplusone
Copy link
Contributor Author

@tkoeppe ping!

@jwakely
Copy link
Member

jwakely commented May 20, 2024

@tkoeppe: You mean for the top line of the git commit? I think the following two lines are if anything too explanatory. :) How about [support.initlist] "initializer list" (syntax construct) should be "initializer_list" (class type)? Also, please let me know whether you're waiting for me to reupload a new commit, or if you're fine with editing the commit message yourself. (I don't mind.)

I'd drop the parentheses: [support.initlist] "initializer list" should be "initializer_list"

This note is talking about the class type, not the grammatical construct,
so it should say `initializer_list`.
@Quuxplusone
Copy link
Contributor Author

I'd drop the parentheses: [support.initlist] "initializer list" should be "initializer_list"

Done!

@jensmaurer jensmaurer merged commit ad37b86 into cplusplus:main May 21, 2024
2 checks passed
@Quuxplusone Quuxplusone deleted the init-list branch June 10, 2024 17:57
jensmaurer pushed a commit to jensmaurer/draft that referenced this pull request Jul 28, 2024
…plusplus#6680)

This note is talking about the class type, not the grammatical construct.
Quuxplusone added a commit to Quuxplusone/draft that referenced this pull request Apr 13, 2025
The removed editorial-nit is now
cplusplus#6680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants