Skip to content

Commit df5a25b

Browse files
committed
context::create_shaders()
1 parent 798b1b8 commit df5a25b

File tree

4 files changed

+30
-29
lines changed

4 files changed

+30
-29
lines changed

src/ruis/render/opengl/context.cpp

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,32 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
1919

2020
/* ================ LICENSE END ================ */
2121

22-
#include "context.hpp"
22+
#include "context.hpp"
23+
24+
#include "shaders/shader_color.hpp"
25+
#include "shaders/shader_color_pos_lum.hpp"
26+
#include "shaders/shader_color_pos_tex.hpp"
27+
#include "shaders/shader_color_pos_tex_alpha.hpp"
28+
#include "shaders/shader_pos_clr.hpp"
29+
#include "shaders/shader_pos_tex.hpp"
30+
31+
using namespace ruis::render::opengl;
32+
33+
utki::shared_ref<ruis::render::context::shaders> context::create_shaders()
34+
{
35+
// TODO: are those lint supressions still valid?
36+
auto ret = utki::make_shared<ruis::render::context::shaders>();
37+
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
38+
ret.get().pos_tex = std::make_unique<shader_pos_tex>();
39+
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
40+
ret.get().color_pos = std::make_unique<shader_color>();
41+
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
42+
ret.get().pos_clr = std::make_unique<shader_pos_clr>();
43+
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
44+
ret.get().color_pos_tex = std::make_unique<shader_color_pos_tex>();
45+
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
46+
ret.get().color_pos_tex_alpha = std::make_unique<shader_color_pos_tex_alpha>();
47+
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
48+
ret.get().color_pos_lum = std::make_unique<shader_color_pos_lum>();
49+
return ret;
50+
}

src/ruis/render/opengl/context.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ namespace ruis::render::opengl {
2828
class context : public ruis::render::context
2929
{
3030
public:
31+
utki::shared_ref<shaders> create_shaders() override;
3132
};
3233

3334
} // namespace ruis::render::opengl

src/ruis/render/opengl/factory.cpp

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
2323

2424
#include <GL/glew.h>
2525

26-
#include "shaders/shader_color.hpp"
27-
#include "shaders/shader_color_pos_lum.hpp"
28-
#include "shaders/shader_color_pos_tex.hpp"
29-
#include "shaders/shader_color_pos_tex_alpha.hpp"
30-
#include "shaders/shader_pos_clr.hpp"
31-
#include "shaders/shader_pos_tex.hpp"
32-
3326
#include "frame_buffer.hpp"
3427
#include "index_buffer.hpp"
3528
#include "texture_2d.hpp"
@@ -245,25 +238,6 @@ utki::shared_ref<ruis::render::index_buffer> factory::create_index_buffer(utki::
245238
);
246239
}
247240

248-
utki::shared_ref<ruis::render::factory::shaders> factory::create_shaders()
249-
{
250-
// TODO: are those lint supressions still valid?
251-
auto ret = utki::make_shared<ruis::render::factory::shaders>();
252-
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
253-
ret.get().pos_tex = std::make_unique<shader_pos_tex>();
254-
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
255-
ret.get().color_pos = std::make_unique<shader_color>();
256-
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
257-
ret.get().pos_clr = std::make_unique<shader_pos_clr>();
258-
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
259-
ret.get().color_pos_tex = std::make_unique<shader_color_pos_tex>();
260-
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
261-
ret.get().color_pos_tex_alpha = std::make_unique<shader_color_pos_tex_alpha>();
262-
// NOLINTNEXTLINE(bugprone-unused-return-value, "false positive")
263-
ret.get().color_pos_lum = std::make_unique<shader_color_pos_lum>();
264-
return ret;
265-
}
266-
267241
utki::shared_ref<ruis::render::frame_buffer> factory::create_framebuffer( //
268242
std::shared_ptr<ruis::render::texture_2d> color,
269243
std::shared_ptr<ruis::render::texture_depth> depth,

src/ruis/render/opengl/factory.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ class factory : public ruis::render::factory
8585
ruis::render::vertex_array::mode mode
8686
) override;
8787

88-
utki::shared_ref<shaders> create_shaders() override;
89-
9088
utki::shared_ref<ruis::render::frame_buffer> create_framebuffer( //
9189
std::shared_ptr<ruis::render::texture_2d> color,
9290
std::shared_ptr<ruis::render::texture_depth> depth,

0 commit comments

Comments
 (0)