Skip to content

Commit c8129b4

Browse files
authored
Merge pull request #50 from cquiroz/scalatest_ports
Test porting
2 parents be7978e + 83a40f8 commit c8129b4

File tree

6 files changed

+60
-43
lines changed

6 files changed

+60
-43
lines changed

jvm/src/test/scala/org/threeten/bp/zone/TestZoneRulesBuilder.scala renamed to shared/src/test/scala/org/threeten/bp/zone/TestZoneRulesBuilder.scala

Lines changed: 60 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ import org.threeten.bp.Month.SEPTEMBER
4747
import org.threeten.bp.zone.ZoneOffsetTransitionRule.TimeDefinition.STANDARD
4848
import org.threeten.bp.zone.ZoneOffsetTransitionRule.TimeDefinition.UTC
4949
import org.threeten.bp.zone.ZoneOffsetTransitionRule.TimeDefinition.WALL
50-
import org.testng.annotations.Test
5150
import org.threeten.bp._
5251

5352
/** Test ZoneRulesBuilder. */
@@ -717,34 +716,44 @@ class TestZoneRulesBuilder extends FunSuite with AssertionsHelper {
717716
}
718717
}
719718

720-
@Test(expectedExceptions = Array(classOf[DateTimeException])) def test_addRuleToWindow_illegalYear1(): Unit = {
721-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
722-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
723-
b.addRuleToWindow(Year.MIN_VALUE - 1, 2008, MARCH, -1, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
719+
test("test_addRuleToWindow_illegalYear1") {
720+
assertThrows[DateTimeException] {
721+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
722+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
723+
b.addRuleToWindow(Year.MIN_VALUE - 1, 2008, MARCH, -1, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
724+
}
724725
}
725726

726-
@Test(expectedExceptions = Array(classOf[DateTimeException])) def test_addRuleToWindow_illegalYear2(): Unit = {
727-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
728-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
729-
b.addRuleToWindow(2000, Year.MIN_VALUE - 1, MARCH, -1, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
727+
test("test_addRuleToWindow_illegalYear2") {
728+
assertThrows[DateTimeException] {
729+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
730+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
731+
b.addRuleToWindow(2000, Year.MIN_VALUE - 1, MARCH, -1, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
732+
}
730733
}
731734

732-
@Test(expectedExceptions = Array(classOf[IllegalArgumentException])) def test_addRuleToWindow_illegalDayOfMonth_tooSmall(): Unit = {
733-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
734-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
735-
b.addRuleToWindow(2000, 2008, MARCH, -29, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
735+
test("test_addRuleToWindow_illegalDayOfMonth_tooSmall") {
736+
assertThrows[IllegalArgumentException] {
737+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
738+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
739+
b.addRuleToWindow(2000, 2008, MARCH, -29, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
740+
}
736741
}
737742

738-
@Test(expectedExceptions = Array(classOf[IllegalArgumentException])) def test_addRuleToWindow_illegalDayOfMonth_zero(): Unit = {
739-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
740-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
741-
b.addRuleToWindow(2000, 2008, MARCH, 0, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
743+
test("test_addRuleToWindow_illegalDayOfMonth_zero") {
744+
assertThrows[IllegalArgumentException] {
745+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
746+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
747+
b.addRuleToWindow(2000, 2008, MARCH, 0, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
748+
}
742749
}
743750

744-
@Test(expectedExceptions = Array(classOf[IllegalArgumentException])) def test_addRuleToWindow_illegalDayOfMonth_tooLarge(): Unit = {
745-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
746-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
747-
b.addRuleToWindow(2000, 2008, MARCH, 32, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
751+
test("test_addRuleToWindow_illegalDayOfMonth_tooLarge") {
752+
assertThrows[IllegalArgumentException] {
753+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
754+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
755+
b.addRuleToWindow(2000, 2008, MARCH, 32, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
756+
}
748757
}
749758

750759
test("addRuleToWindow_nullMonth") {
@@ -763,10 +772,12 @@ class TestZoneRulesBuilder extends FunSuite with AssertionsHelper {
763772
}
764773
}
765774

766-
@Test(expectedExceptions = Array(classOf[IllegalArgumentException])) def test_addRuleToWindow_illegalEndOfDayTime(): Unit = {
767-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
768-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
769-
b.addRuleToWindow(2000, 2008, MARCH, 1, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = true, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
775+
test("test_addRuleToWindow_illegalEndOfDayTime") {
776+
assertThrows[IllegalArgumentException] {
777+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
778+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
779+
b.addRuleToWindow(2000, 2008, MARCH, 1, SUNDAY, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = true, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
780+
}
770781
}
771782

772783
test("addRuleToWindow_nullTimeDefinition") {
@@ -837,28 +848,36 @@ class TestZoneRulesBuilder extends FunSuite with AssertionsHelper {
837848
}
838849
}
839850

840-
@Test(expectedExceptions = Array(classOf[DateTimeException])) def test_addRuleToWindow_singleYear_illegalYear(): Unit = {
841-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
842-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
843-
b.addRuleToWindow(Year.MIN_VALUE - 1, MARCH, 31, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
851+
test("test_addRuleToWindow_singleYear_illegalYear") {
852+
assertThrows[DateTimeException] {
853+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
854+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
855+
b.addRuleToWindow(Year.MIN_VALUE - 1, MARCH, 31, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
856+
}
844857
}
845858

846-
@Test(expectedExceptions = Array(classOf[IllegalArgumentException])) def test_addRuleToWindow_singleYear_illegalDayOfMonth_tooSmall(): Unit = {
847-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
848-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
849-
b.addRuleToWindow(2000, MARCH, -29, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
859+
test("test_addRuleToWindow_singleYear_illegalDayOfMonth_tooSmall") {
860+
assertThrows[IllegalArgumentException] {
861+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
862+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
863+
b.addRuleToWindow(2000, MARCH, -29, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
864+
}
850865
}
851866

852-
@Test(expectedExceptions = Array(classOf[IllegalArgumentException])) def test_addRuleToWindow_singleYear_illegalDayOfMonth_zero(): Unit = {
853-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
854-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
855-
b.addRuleToWindow(2000, MARCH, 0, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
867+
test("test_addRuleToWindow_singleYear_illegalDayOfMonth_zero") {
868+
assertThrows[IllegalArgumentException] {
869+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
870+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
871+
b.addRuleToWindow(2000, MARCH, 0, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
872+
}
856873
}
857874

858-
@Test(expectedExceptions = Array(classOf[IllegalArgumentException])) def test_addRuleToWindow_singleYear_illegalDayOfMonth_tooLarge(): Unit = {
859-
val b: ZoneRulesBuilder = new ZoneRulesBuilder
860-
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
861-
b.addRuleToWindow(2000, MARCH, 32, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
875+
test("test_addRuleToWindow_singleYear_illegalDayOfMonth_tooLarge") {
876+
assertThrows[IllegalArgumentException] {
877+
val b: ZoneRulesBuilder = new ZoneRulesBuilder
878+
b.addWindowForever(TestZoneRulesBuilder.OFFSET_1)
879+
b.addRuleToWindow(2000, MARCH, 32, TestZoneRulesBuilder.time(1, 0), timeEndOfDay = false, WALL, TestZoneRulesBuilder.PERIOD_1HOUR30MIN)
880+
}
862881
}
863882

864883
test("addRuleToWindow_singleYear_nullMonth") {

jvm/src/test/scala/org/threeten/bp/UsabilityBasic.scala renamed to shared/src/test/scala/org/threeten/bp/zone/UsabilityBasic.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@
3131
*/
3232
package org.threeten.bp
3333

34-
import org.testng.annotations.Test
35-
3634
import org.threeten.bp.temporal.ChronoField.DAY_OF_MONTH
3735
import org.threeten.bp.temporal.TemporalAdjusters.previousOrSame
3836
import org.threeten.bp.format.DateTimeFormatter

0 commit comments

Comments
 (0)