Minor fixes :)

Author: JustFanta01

data/src/main/java/org/cryptomator/data/cloud/crypto/CryptoImplDecorator.kt

@@ -121,7 +121,7 @@ abstract class CryptoImplDecorator(
 			CloudType.WEBDAV -> LruFileCacheUtil.Cache.WEBDAV
 			CloudType.S3 -> LruFileCacheUtil.Cache.S3
 			CloudType.LOCAL -> LruFileCacheUtil.Cache.LOCAL
-			else -> throw IllegalStateException()
+			else -> throw IllegalStateException("Unexpected CloudType: $type")
 		}
 	}
 
@@ -458,6 +458,11 @@ abstract class CryptoImplDecorator(
 				val thumbnailBitmap: Bitmap?
 				options.inSampleSize = 4 // pixel number reduced by a factor of 1/16
 				val bitmap = BitmapFactory.decodeStream(thumbnailReader, null, options)
+				if (bitmap == null) {
+					closeQuietly(thumbnailReader)
+					return@submit
+				}
+
 				val thumbnailWidth = 100
 				val thumbnailHeight = 100
 				thumbnailBitmap = ThumbnailUtils.extractThumbnail(bitmap, thumbnailWidth, thumbnailHeight)
@@ -468,7 +473,7 @@ abstract class CryptoImplDecorator(
 
 				cryptoFile.thumbnail = diskCache[cacheKey]
 			} catch (e: Exception) {
-				Timber.e("Bitmap generation crashed")
+				Timber.e(e, "Bitmap generation crashed")
 			}
 		}
 	}
@@ -511,7 +516,7 @@ abstract class CryptoImplDecorator(
 		}
 		Timber.tag("THUMBNAIL").i("[AssociateThumbnails] associated:${associated} files, elapsed:${elapsed}ms")
 	}
-	
+
 	private fun isGenerateThumbnailsEnabled(): Boolean {
 		return sharedPreferencesHandler.useLruCache() && sharedPreferencesHandler.generateThumbnails() != ThumbnailsOption.NEVER
 	}

presentation/src/main/java/org/cryptomator/presentation/presenter/BrowseFilesPresenter.kt

@@ -293,21 +293,19 @@ class BrowseFilesPresenter @Inject constructor( //
 		}
 		associateThumbnailsUseCase.withList(cloudNodes)
 			.run(object : DefaultProgressAwareResultHandler<Void, FileTransferState>() {
-				@Override
 				override fun onProgress(progress: Progress<FileTransferState>) {
 					val state = progress.state()
 					state?.let { state ->
 						view?.addOrUpdateCloudNode(cloudFileModelMapper.toModel(state.file()))
 					}
 				}
 
-				@Override
 				override fun onFinished() {
 					val images = view?.renderedCloudNodes()?.filterIsInstance<CloudFileModel>()?.filter { file -> isImageMediaType(file.name) } ?: return
-					val firstImages = images.subList(0, 10)
-					val noThumbnailImages = firstImages.filter { img -> img.thumbnail == null }
-					if (noThumbnailImages.isNotEmpty()) {
-						thumbnailsForVisibleNodes(noThumbnailImages)
+					images.take(10).filter { img -> img.thumbnail == null }.let { firstImagesWithoutThumbnails ->
+						if (firstImagesWithoutThumbnails.isNotEmpty()) {
+							thumbnailsForVisibleNodes(firstImagesWithoutThumbnails)
+						}
 					}
 				}
 			})

presentation/src/main/java/org/cryptomator/presentation/ui/fragment/BrowseFilesFragment.kt

@@ -6,11 +6,12 @@ import android.util.TypedValue
 import android.view.View
 import android.view.View.GONE
 import android.view.View.VISIBLE
-import android.widget.AbsListView.OnScrollListener.SCROLL_STATE_IDLE
 import android.widget.RelativeLayout
 import androidx.core.content.ContextCompat
 import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
+import androidx.recyclerview.widget.RecyclerView.NO_POSITION
+import androidx.recyclerview.widget.RecyclerView.SCROLL_STATE_IDLE
 import androidx.swiperefreshlayout.widget.SwipeRefreshLayout
 import com.simplecityapps.recyclerview_fastscroll.interfaces.OnFastScrollStateChangeListener
 import org.cryptomator.domain.CloudNode
@@ -144,6 +145,9 @@ class BrowseFilesFragment : BaseFragment<FragmentBrowseFilesBinding>(FragmentBro
 		val layoutManager = binding.recyclerViewLayout.recyclerView.layoutManager as LinearLayoutManager
 		val first = layoutManager.findFirstVisibleItemPosition()
 		val last = layoutManager.findLastVisibleItemPosition()
+		if (first == NO_POSITION || last == NO_POSITION) {
+			return
+		}
 		val visibleCloudNodes = cloudNodesAdapter.renderedCloudNodes().subList(first, last + 1)
 		if (!binding.swipeRefreshLayout.isRefreshing) {
 			browseFilesPresenter.thumbnailsForVisibleNodes(visibleCloudNodes)