Add rest of position flags to Parser

Author: drwl

lib/parser.rb

@@ -44,6 +44,42 @@ def parser(options)
           ENV[key] = p unless has_set_position[key]
         end
       end
+
+      opts.on('--pc', '--position-in-class [before|top|after|bottom]', positions,
+              'Place the annotations at the top (before) or the bottom (after) of the model file') do |p|
+        ENV['position_in_class'] = p
+        has_set_position['position_in_class'] = true
+      end
+
+      opts.on('--pf', '--position-in-factory [before|top|after|bottom]', positions,
+              'Place the annotations at the top (before) or the bottom (after) of any factory files') do |p|
+        ENV['position_in_factory'] = p
+        has_set_position['position_in_factory'] = true
+      end
+
+      opts.on('--px', '--position-in-fixture [before|top|after|bottom]', positions,
+              'Place the annotations at the top (before) or the bottom (after) of any fixture files') do |p|
+        ENV['position_in_fixture'] = p
+        has_set_position['position_in_fixture'] = true
+      end
+
+      opts.on('--pt', '--position-in-test [before|top|after|bottom]', positions,
+              'Place the annotations at the top (before) or the bottom (after) of any test files') do |p|
+        ENV['position_in_test'] = p
+        has_set_position['position_in_test'] = true
+      end
+
+      opts.on('--pr', '--position-in-routes [before|top|after|bottom]', positions,
+              'Place the annotations at the top (before) or the bottom (after) of the routes.rb file') do |p|
+        ENV['position_in_routes'] = p
+        has_set_position['position_in_routes'] = true
+      end
+
+      opts.on('--ps', '--position-in-serializer [before|top|after|bottom]', positions,
+              'Place the annotations at the top (before) or the bottom (after) of the serializer files') do |p|
+        ENV['position_in_serializer'] = p
+        has_set_position['position_in_serializer'] = true
+      end
     end
   end
 

spec/parser_spec.rb

@@ -20,7 +20,7 @@
     end
   end
 
-  ['-p', '--position'].each do |option|
+  %w[-p --position].each do |option|
     describe option do
       Parser::ANNOTATION_POSITIONS.each do |position|
         context "when specifying #{position}" do
@@ -30,16 +30,113 @@
           end
 
           it "sets ENV['position'] to be position" do
+            allow(ENV).to receive(:[]=)
             Parser.parse([option, position])
-            expect(ENV['position']).to eq(position)
+
+            expect(ENV).to have_received(:[]=).with('position', position)
           end
 
           it 'sets the value in ENV for the different file types' do
+            allow(ENV).to receive(:[]=)
             Parser.parse([option, position])
+
             Parser::FILE_TYPE_POSITIONS.each do |file_type|
-              expect(ENV[file_type]).to eq(position)
+              expect(ENV).to have_received(:[]=).with(file_type, position)
             end
           end
+
+          context 'the ENV value for different file type has already been set' do
+          end
+        end
+      end
+    end
+  end
+
+  %w[--pc --position-in-class].each do |option|
+    describe option do
+      let(:env_key) { 'position_in_class' }
+
+      Parser::ANNOTATION_POSITIONS.each do |position|
+        context "when specifying '#{position}'" do
+          it "sets the ENV variable to '#{position}'" do
+            expect(ENV).to receive(:[]=).with(env_key, position)
+            Parser.parse([option, position])
+          end
+        end
+      end
+    end
+  end
+
+  %w[--pf --position-in-factory].each do |option|
+    describe option do
+      let(:env_key) { 'position_in_factory' }
+
+      Parser::ANNOTATION_POSITIONS.each do |position|
+        context "when specifying #{position}" do
+          it "sets the ENV variable to #{position}" do
+            expect(ENV).to receive(:[]=).with(env_key, position)
+            Parser.parse([option, position])
+          end
+        end
+      end
+    end
+  end
+
+  %w[--px --position-in-fixture].each do |option|
+    describe option do
+      let(:env_key) { 'position_in_fixture' }
+
+      Parser::ANNOTATION_POSITIONS.each do |position|
+        context "when specifying #{position}" do
+          it "sets the ENV variable to #{position}" do
+            expect(ENV).to receive(:[]=).with(env_key, position)
+            Parser.parse([option, position])
+          end
+        end
+      end
+    end
+  end
+
+  %w[--pt --position-in-test].each do |option|
+    describe option do
+      let(:env_key) { 'position_in_test' }
+
+      Parser::ANNOTATION_POSITIONS.each do |position|
+        context "when specifying #{position}" do
+          it "sets the ENV variable to #{position}" do
+            expect(ENV).to receive(:[]=).with(env_key, position)
+            Parser.parse([option, position])
+          end
+        end
+      end
+    end
+  end
+
+  %w[--pr --position-in-routes].each do |option|
+    describe option do
+      let(:env_key) { 'position_in_routes' }
+
+      Parser::ANNOTATION_POSITIONS.each do |position|
+        context "when specifying #{position}" do
+          it "sets the ENV variable to #{position}" do
+            expect(ENV).to receive(:[]=).with(env_key, position)
+            Parser.parse([option, position])
+          end
+        end
+      end
+    end
+  end
+
+  %w[--ps --position-in-serializer].each do |option|
+    describe option do
+      let(:env_key) { 'position_in_serializer' }
+
+      Parser::ANNOTATION_POSITIONS.each do |position|
+        context "when specifying #{position}" do
+          it "sets the ENV variable to #{position}" do
+            expect(ENV).to receive(:[]=).with(env_key, position)
+            Parser.parse([option, position])
+          end
         end
       end
     end