Handle missing expression

Signed-off-by: Lovro Bikic <[email protected]>

Author: lovro-bikic

lib/annotate/annotate_models.rb

@@ -371,10 +371,14 @@ def get_check_constraint_info(klass, options = {})
 
       max_size = check_constraints.map { |check_constraint| check_constraint.name.size }.max + 1
       check_constraints.sort_by(&:name).each do |check_constraint|
+        expression = check_constraint.expression ? "(#{check_constraint.expression.squish})" : nil
+
         cc_info << if options[:format_markdown]
-                     sprintf("# * `%s`: `(%s)`\n", check_constraint.name, check_constraint.expression.squish)
+                     cc_info_markdown = sprintf("# * `%s`", check_constraint.name)
+                     cc_info_markdown << sprintf(": `%s`", expression) if expression
+                     cc_info_markdown << "\n"
                    else
-                     sprintf("#  %-#{max_size}.#{max_size}s (%s)\n", check_constraint.name, check_constraint.expression.squish)
+                     sprintf("#  %-#{max_size}.#{max_size}s %s", check_constraint.name, expression).rstrip + "\n"
                    end
       end
 

spec/lib/annotate/annotate_models_spec.rb

@@ -788,6 +788,7 @@ def mock_column(name, type, options = {})
                     [
                       mock_check_constraint('alive', 'age < 150'),
                       mock_check_constraint('must_be_adult', 'age >= 18'),
+                      mock_check_constraint('missing_expression', nil),
                       mock_check_constraint('multiline_test', <<~SQL)
                         CASE
                           WHEN (age >= 18) THEN (age <= 21)
@@ -808,9 +809,10 @@ def mock_column(name, type, options = {})
                       #
                       # Check Constraints
                       #
-                      #  alive           (age < 150)
-                      #  multiline_test  (CASE WHEN (age >= 18) THEN (age <= 21) ELSE true END)
-                      #  must_be_adult   (age >= 18)
+                      #  alive               (age < 150)
+                      #  missing_expression
+                      #  multiline_test      (CASE WHEN (age >= 18) THEN (age <= 21) ELSE true END)
+                      #  must_be_adult       (age >= 18)
                       #
                     EOS
                   end
@@ -1589,6 +1591,7 @@ def mock_column(name, type, options = {})
                   let :check_constraints do
                     [
                       mock_check_constraint('min_name_length', 'LENGTH(name) > 2'),
+                      mock_check_constraint('missing_expression', nil),
                       mock_check_constraint('multiline_test', <<~SQL)
                         CASE
                           WHEN (age >= 18) THEN (age <= 21)
@@ -1614,6 +1617,7 @@ def mock_column(name, type, options = {})
                       # ### Check Constraints
                       #
                       # * `min_name_length`: `(LENGTH(name) > 2)`
+                      # * `missing_expression`
                       # * `multiline_test`: `(CASE WHEN (age >= 18) THEN (age <= 21) ELSE true END)`
                       #
                     EOS