File tree Expand file tree Collapse file tree 2 files changed +5
-3
lines changed
cucumber-core/src/main/java/io/cucumber/core/runner Expand file tree Collapse file tree 2 files changed +5
-3
lines changed Original file line number Diff line number Diff line change @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
12
12
## [ Unreleased]
13
13
### Fixed
14
14
- [ Core] Include root cause when using DataTable.asList and friends ([ #2949 ] ( https://github.com/cucumber/cucumber-jvm/pull/2949 ) M.P. Korstanje)
15
+ - [ Core] Improve caching glue performance ([ #2971 ] ( https://github.com/cucumber/cucumber-jvm/pull/2971 ) M.P. Korstanje & Julien Kronegg)
15
16
- [ JUnit Platform Engine] Set Engine-Version-cucumber attribute ([ #2963 ] ( https://github.com/cucumber/cucumber-jvm/pull/2963 ) M.P. Korstanje)
16
17
17
18
### Changed
Original file line number Diff line number Diff line change @@ -245,16 +245,17 @@ void prepareGlue(Locale locale) throws DuplicateStepDefinitionException {
245
245
boolean firstTime = stepTypeRegistry == null ;
246
246
boolean languageChanged = !locale .equals (this .locale );
247
247
boolean mustRebuildCache = false ;
248
- if (firstTime || languageChanged || this . dirtyCache ) {
248
+ if (firstTime || languageChanged || dirtyCache ) {
249
249
// conditions changed => invalidate the glue cache
250
250
this .locale = locale ;
251
251
stepTypeRegistry = new StepTypeRegistry (locale );
252
252
stepExpressionFactory = new StepExpressionFactory (stepTypeRegistry , bus );
253
253
stepDefinitionsByPattern .clear ();
254
254
stepPatternByStepText .clear ();
255
255
mustRebuildCache = true ;
256
- this .dirtyCache = false ; // since we must rebuild the cache, it will
257
- // not be dirty the next time
256
+ // since we must rebuild the cache, it will not be dirty the next
257
+ // time
258
+ dirtyCache = false ;
258
259
}
259
260
260
261
// TODO: separate prepared and unprepared glue into different classes
You can’t perform that action at this time.
0 commit comments