Skip to content

Commit 87b2ee4

Browse files
brasmussonbrasmusson
committed
Align the step results in the JUnit test result files
Adjust the number of . separating the step text from the step result, so that the results are aligned.
1 parent 11ac9ff commit 87b2ee4

File tree

3 files changed

+28
-26
lines changed

3 files changed

+28
-26
lines changed

‎core/src/main/java/cucumber/runtime/formatter/JUnitFormatter.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,9 @@ public void updateElement(Document doc, Element tc) {
224224
if ("undefined".equals(result.getStatus()) || "pending".equals(result.getStatus())) skipped = result;
225225
sb.append(steps.get(i).getKeyword());
226226
sb.append(steps.get(i).getName());
227-
for (int j = 0; sb.length() - length + j < 140; j++) sb.append(".");
227+
do {
228+
sb.append(".");
229+
} while (sb.length() - length < 76);
228230
sb.append(result.getStatus());
229231
sb.append("\n");
230232
}

‎core/src/test/resources/cucumber/runtime/formatter/JUnitFormatterTest_2.report.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
22
<testsuite tests="2" failures="0">
33
<testcase classname="Feature_2" name="Scenario_1" time="0">
4-
<skipped><![CDATA[Given bg_1.................................................................undefined
5-
When bg_2..................................................................undefined
6-
Then bg_3..................................................................undefined
4+
<skipped><![CDATA[Given bg_1..................................................................undefined
5+
When bg_2...................................................................undefined
6+
Then bg_3...................................................................undefined
77
Given step_1................................................................undefined
88
When step_2.................................................................undefined
99
Then step_3.................................................................undefined
1010
]]></skipped>
1111
</testcase>
1212
<testcase classname="Feature_2" name="Scenario_2" time="0">
13-
<skipped><![CDATA[Given bg_1.................................................................undefined
14-
When bg_2..................................................................undefined
15-
Then bg_3..................................................................undefined
13+
<skipped><![CDATA[Given bg_1..................................................................undefined
14+
When bg_2...................................................................undefined
15+
Then bg_3...................................................................undefined
1616
Given step_1................................................................undefined
1717
When step_2.................................................................undefined
1818
Then step_3.................................................................undefined

‎core/src/test/resources/cucumber/runtime/formatter/JUnitFormatterTest_3.report.xml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,39 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
22
<testsuite failures="0" tests="4">
33
<testcase classname="Feature_3" name="Scenario_1" time="0">
4-
<skipped><![CDATA[Given bg_1.................................................................undefined
5-
When bg_2..................................................................undefined
6-
Then bg_3..................................................................undefined
4+
<skipped><![CDATA[Given bg_1..................................................................undefined
5+
When bg_2...................................................................undefined
6+
Then bg_3...................................................................undefined
77
Given step_1................................................................undefined
88
When step_2.................................................................undefined
99
Then step_3.................................................................undefined
1010
]]></skipped>
1111
</testcase>
1212
<testcase classname="Feature_3" name="ScenarioOutline_1_2" time="0">
13-
<skipped><![CDATA[Given bg_1.................................................................undefined
14-
When bg_2..................................................................undefined
15-
Then bg_3..................................................................undefined
16-
Given so_1 12................................................................undefined
17-
When so_2 7 cucumbers............................................................undefined
13+
<skipped><![CDATA[Given bg_1..................................................................undefined
14+
When bg_2...................................................................undefined
15+
Then bg_3...................................................................undefined
16+
Given so_1 12...............................................................undefined
17+
When so_2 7 cucumbers.......................................................undefined
1818
Then 5 so_3.................................................................undefined
1919
]]></skipped>
2020
</testcase>
2121
<testcase classname="Feature_3" name="ScenarioOutline_1_1" time="0">
22-
<skipped><![CDATA[Given bg_1.................................................................undefined
23-
When bg_2..................................................................undefined
24-
Then bg_3..................................................................undefined
25-
Given so_1 20................................................................undefined
26-
When so_2 15 cucumbers...........................................................undefined
22+
<skipped><![CDATA[Given bg_1..................................................................undefined
23+
When bg_2...................................................................undefined
24+
Then bg_3...................................................................undefined
25+
Given so_1 20...............................................................undefined
26+
When so_2 15 cucumbers......................................................undefined
2727
Then 5 so_3.................................................................undefined
2828
]]></skipped>
2929
</testcase>
3030
<testcase classname="Feature_3" name="Scenario_2" time="0">
31-
<skipped><![CDATA[Given bg_1.................................................................undefined
32-
When bg_2..................................................................undefined
33-
Then bg_3..................................................................undefined
34-
Given a...................................................................undefined
35-
Then b...................................................................undefined
36-
When c...................................................................undefined
31+
<skipped><![CDATA[Given bg_1..................................................................undefined
32+
When bg_2...................................................................undefined
33+
Then bg_3...................................................................undefined
34+
Given a.....................................................................undefined
35+
Then b......................................................................undefined
36+
When c......................................................................undefined
3737
]]></skipped>
3838
</testcase>
3939
</testsuite>

0 commit comments

Comments
 (0)