Skip to content

Commit 999493e

Browse files
committed
Update CHANGELOG
1 parent 52b7d98 commit 999493e

File tree

3 files changed

+8
-58
lines changed

3 files changed

+8
-58
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
## [Unreleased]
1313
### Changed
1414
- [Core] Improved caching glue performance ([#2971](https://github.com/cucumber/cucumber-jvm/pull/2971) M.P. Korstanje & Julien Kronegg)
15+
- [Java, Java8] Significantly reduced number of emitted step- and hook-definition messages ([#2971](https://github.com/cucumber/cucumber-jvm/pull/2971) M.P. Korstanje & Julien Kronegg)
16+
- [Core] Removed workarounds to limit size of html report ([#2971](https://github.com/cucumber/cucumber-jvm/pull/2971) M.P. Korstanje & Julien Kronegg)
17+
18+
### Deprecated
19+
- [Core] Deprecated `ScenarioScoped` glue ([#2971](https://github.com/cucumber/cucumber-jvm/pull/2971) M.P. Korstanje & Julien Kronegg)
1520

1621
## [7.21.1] - 2025-02-07
1722
### Fixed

cucumber-core/src/main/java/io/cucumber/core/backend/ScenarioScoped.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
* scenario scoped object (e.g. a method closure).
99
*
1010
* @deprecated backend with scenario scoped glue should hide this complexity
11-
* from Cucumber by updating the registered glue during
12-
* {@link Backend#buildWorld()} and transparently dispose of any closures during
13-
* {@link Backend#disposeWorld()}.
11+
* from Cucumber by updating the registered glue during
12+
* {@link Backend#buildWorld()} and transparently dispose of any
13+
* closures during {@link Backend#disposeWorld()}.
1414
*/
1515
@Deprecated
1616
public interface ScenarioScoped {

cucumber-core/src/test/java/io/cucumber/core/plugin/HtmlFormatterTest.java

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,13 @@
33
import io.cucumber.core.eventbus.EventBus;
44
import io.cucumber.core.runtime.TimeServiceEventBus;
55
import io.cucumber.messages.types.Envelope;
6-
import io.cucumber.messages.types.Hook;
7-
import io.cucumber.messages.types.ParameterType;
8-
import io.cucumber.messages.types.SourceReference;
9-
import io.cucumber.messages.types.StepDefinition;
10-
import io.cucumber.messages.types.StepDefinitionPattern;
11-
import io.cucumber.messages.types.StepDefinitionPatternType;
126
import io.cucumber.messages.types.TestRunFinished;
137
import io.cucumber.messages.types.TestRunStarted;
148
import io.cucumber.messages.types.Timestamp;
159
import org.junit.jupiter.api.Test;
1610

1711
import java.io.ByteArrayOutputStream;
1812
import java.time.Clock;
19-
import java.util.Collections;
2013
import java.util.UUID;
2114
import java.util.regex.Matcher;
2215
import java.util.regex.Pattern;
@@ -48,54 +41,6 @@ void writes_index_html() throws Throwable {
4841
extractCucumberMessages(bytes), STRICT);
4942
}
5043

51-
@Test
52-
void ignores_step_definitions() throws Throwable {
53-
ByteArrayOutputStream bytes = new ByteArrayOutputStream();
54-
HtmlFormatter formatter = new HtmlFormatter(bytes);
55-
EventBus bus = new TimeServiceEventBus(Clock.systemUTC(), UUID::randomUUID);
56-
formatter.setEventPublisher(bus);
57-
58-
TestRunStarted testRunStarted = new TestRunStarted(new Timestamp(10L, 0L), null);
59-
bus.send(Envelope.of(testRunStarted));
60-
61-
StepDefinition stepDefinition = new StepDefinition(
62-
"",
63-
new StepDefinitionPattern("", StepDefinitionPatternType.CUCUMBER_EXPRESSION),
64-
SourceReference.of("https://example.com"));
65-
bus.send(Envelope.of(stepDefinition));
66-
67-
Hook hook = new Hook("",
68-
null,
69-
SourceReference.of("https://example.com"),
70-
null, null);
71-
bus.send(Envelope.of(hook));
72-
73-
// public ParameterType(String name, List<String> regularExpressions,
74-
// Boolean preferForRegularExpressionMatch, Boolean useForSnippets,
75-
// String id) {
76-
ParameterType parameterType = new ParameterType(
77-
"",
78-
Collections.emptyList(),
79-
true,
80-
false,
81-
"",
82-
null);
83-
bus.send(Envelope.of(parameterType));
84-
85-
TestRunFinished testRunFinished = new TestRunFinished(
86-
null,
87-
true,
88-
new Timestamp(15L, 0L),
89-
null, null);
90-
bus.send(Envelope.of(testRunFinished));
91-
92-
assertEquals("[" +
93-
"{\"testRunStarted\":{\"timestamp\":{\"nanos\":0,\"seconds\":10}}}," +
94-
"{\"testRunFinished\":{\"success\":true,\"timestamp\":{\"nanos\":0,\"seconds\":15}}}" +
95-
"]",
96-
extractCucumberMessages(bytes), STRICT);
97-
}
98-
9944
private static String extractCucumberMessages(ByteArrayOutputStream bytes) {
10045
Pattern pattern = Pattern.compile("^.*window\\.CUCUMBER_MESSAGES = (\\[.+]);.*$", Pattern.DOTALL);
10146
Matcher matcher = pattern.matcher(new String(bytes.toByteArray(), UTF_8));

0 commit comments

Comments
 (0)