Skip to content

Commit 49d7f0b

Browse files
ntilwallijvanbruegge
authored andcommitted
Throw if composed stream emits array (#18)
1 parent 1c317da commit 49d7f0b

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
},
4343
"dependencies": {
4444
"@cycle/run": "^3.0.0",
45-
"snabbdom-selector": "^1.2.0",
45+
"snabbdom-selector": "^1.3.2",
4646
"xstream": "^11.0.0"
4747
},
4848
"devDependencies": {

src/helpers.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ export function addKeys(
5050
node: VNode,
5151
key: string = Math.random().toString()
5252
): VNode {
53+
if (!node) return;
54+
5355
if (!node.children) {
5456
return { ...node, key: node.key ? node.key : key };
5557
}

src/makeSortable.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ function augmentStartDistance(
3737
}
3838

3939
function moreThanOneChild(node: VNode) {
40-
return !node.children || node.children.length > 1;
40+
if (Array.isArray(node)) {
41+
throw new Error('Composed stream should emit VNodes not arrays');
42+
}
43+
44+
return !node || node.children.length > 1;
4145
}
4246

4347
function notMoreThanOneChild(node: VNode) {

0 commit comments

Comments
 (0)