Skip to content

Commit 7037e94

Browse files
committed
vulkan: subgroup size test
1 parent 19d3c82 commit 7037e94

File tree

1 file changed

+52
-1
lines changed

1 file changed

+52
-1
lines changed

ggml/src/ggml-vulkan/ggml-vulkan.cpp

Lines changed: 52 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1423,6 +1423,49 @@ static bool ggml_vk_matmul_shmem_support(const vk_device& device, const std::vec
14231423
return supported;
14241424
}
14251425

1426+
struct GpuPipelineConfig {
1427+
// List of all aliases for a given GPU.
1428+
// For example, this can include names like "NAVI10", "RX 5700", etc.
1429+
std::vector<std::string> device_names;
1430+
1431+
// Mapping of pipeline names to their specific subgroup sizes.
1432+
// Example: {"soft_max_f32", 64}.
1433+
std::unordered_map<std::string, uint32_t> pipelines;
1434+
1435+
// Default subgroup size for this GPU.
1436+
// Defaults to 0 if not explicitly provided.
1437+
uint32_t default_subgroup_size = 0;
1438+
};
1439+
1440+
// Define configurations for different GPUs.
1441+
static std::vector<GpuPipelineConfig> gpu_pipeline_configs = {
1442+
{
1443+
{"NAVI10", "NAVI14", "RX 5700", "RX 5600", "RX 5500"},
1444+
{
1445+
{"soft_max_f32", 64}, {"soft_max_f32_wg512", 64},
1446+
{"soft_max_f32_f16", 64}, {"soft_max_f32_f16_wg512", 64},
1447+
{"im2col_f32", 64}, {"im2col_f32_f16", 64},
1448+
},
1449+
32
1450+
},
1451+
};
1452+
1453+
static uint32_t get_subgroup_size(const std::string &pipeline_name, const std::string &device_name) {
1454+
for (const auto &config : gpu_pipeline_configs) {
1455+
for (const auto &alias : config.device_names) {
1456+
if (device_name.find(alias) != std::string::npos) {
1457+
auto pipIt = config.pipelines.find(pipeline_name);
1458+
if (pipIt != config.pipelines.end() && pipIt->second != 0) {
1459+
return pipIt->second;
1460+
}
1461+
return config.default_subgroup_size;
1462+
}
1463+
}
1464+
}
1465+
// If no matching configuration is found, return 0.
1466+
return 0;
1467+
}
1468+
14261469
static void ggml_vk_load_shaders(vk_device& device) {
14271470
VK_LOG_DEBUG("ggml_vk_load_shaders(" << device->name << ")");
14281471

@@ -1543,11 +1586,17 @@ static void ggml_vk_load_shaders(vk_device& device) {
15431586
device->pipeline_matmul_id_f32 = std::make_shared<vk_matmul_pipeline_struct>();
15441587
}
15451588

1589+
vk::PhysicalDeviceProperties2 props2;
1590+
device->physical_device.getProperties2(&props2);
1591+
std::string device_name = props2.properties.deviceName.data();
1592+
15461593
std::vector<std::future<void>> compiles;
15471594
auto const &ggml_vk_create_pipeline = [&](vk_device& device, vk_pipeline& pipeline, const std::string &name, size_t spv_size, const void* spv_data, const std::string &entrypoint,
15481595
uint32_t parameter_count, uint32_t push_constant_size, std::array<uint32_t, 3> wg_denoms, const std::vector<uint32_t>& specialization_constants,
15491596
uint32_t align, bool disable_robustness = false, bool require_full_subgroups = false, uint32_t required_subgroup_size = 0) {
15501597

1598+
required_subgroup_size = get_subgroup_size(name, device_name);
1599+
15511600
if (!pipeline) {
15521601
pipeline = std::make_shared<vk_pipeline_struct>();
15531602
pipeline->name = name;
@@ -2699,7 +2748,9 @@ static void ggml_vk_print_gpu_info(size_t idx) {
26992748
subgroup_props.pNext = &driver_props;
27002749
physical_device.getProperties2(&props2);
27012750

2702-
const size_t subgroup_size = subgroup_props.subgroupSize;
2751+
uint32_t default_subgroup_size = get_subgroup_size("", props2.properties.deviceName.data());
2752+
const size_t subgroup_size = (default_subgroup_size != 0) ? default_subgroup_size : subgroup_props.subgroupSize;
2753+
27032754
const bool uma = props2.properties.deviceType == vk::PhysicalDeviceType::eIntegratedGpu;
27042755

27052756
bool fp16_storage = false;

0 commit comments

Comments
 (0)