Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Commit 49d110e

Browse files
committed
chore: extract reusable function
1 parent 579ba50 commit 49d110e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lib/src/analyzers/lint_analyzer/rules/rules_list/no_equal_arguments/visitor.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,15 @@ class _Visitor extends RecursiveAstVisitor<void> {
4040
arg is NamedExpression &&
4141
argument.expression is! Literal &&
4242
arg.expression is! Literal) {
43-
return argument.expression.staticParameterElement?.type ==
44-
arg.expression.staticParameterElement?.type &&
43+
return haveSameParameterType(argument.expression, arg.expression) &&
4544
argument.expression.toString() == arg.expression.toString();
4645
}
4746

4847
if (_bothLiterals(argument, arg)) {
4948
return argument == arg;
5049
}
5150

52-
return argument.staticParameterElement?.type ==
53-
arg.staticParameterElement?.type &&
51+
return haveSameParameterType(argument, arg) &&
5452
argument.toString() == arg.toString();
5553
});
5654

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_moving_to_variable/visitor.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,5 @@ class _BlockVisitor extends RecursiveAstVisitor<void> {
201201
bool _haveDifferentParameterTypes(AstNode visitedInvocation, AstNode node) =>
202202
visitedInvocation is Expression &&
203203
node is Expression &&
204-
visitedInvocation.staticParameterElement?.type !=
205-
node.staticParameterElement?.type;
204+
!haveSameParameterType(visitedInvocation, node);
206205
}

lib/src/utils/node_utils.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ bool isOverride(List<Annotation> metadata) => metadata.any(
4343
node.name.name == 'override' && node.atSign.type == TokenType.AT,
4444
);
4545

46+
bool haveSameParameterType(Expression left, Expression right) =>
47+
left.staticParameterElement?.type == right.staticParameterElement?.type;
48+
4649
bool isEntrypoint(String name, NodeList<Annotation> metadata) =>
4750
name == 'main' ||
4851
_hasPragmaAnnotation(metadata) ||

0 commit comments

Comments
 (0)