This repository was archived by the owner on Jul 16, 2023. It is now read-only.
File tree Expand file tree Collapse file tree 3 files changed +6
-6
lines changed
analyzers/lint_analyzer/rules/rules_list
prefer_moving_to_variable Expand file tree Collapse file tree 3 files changed +6
-6
lines changed Original file line number Diff line number Diff line change @@ -40,17 +40,15 @@ class _Visitor extends RecursiveAstVisitor<void> {
40
40
arg is NamedExpression &&
41
41
argument.expression is ! Literal &&
42
42
arg.expression is ! Literal ) {
43
- return argument.expression.staticParameterElement? .type ==
44
- arg.expression.staticParameterElement? .type &&
43
+ return haveSameParameterType (argument.expression, arg.expression) &&
45
44
argument.expression.toString () == arg.expression.toString ();
46
45
}
47
46
48
47
if (_bothLiterals (argument, arg)) {
49
48
return argument == arg;
50
49
}
51
50
52
- return argument.staticParameterElement? .type ==
53
- arg.staticParameterElement? .type &&
51
+ return haveSameParameterType (argument, arg) &&
54
52
argument.toString () == arg.toString ();
55
53
});
56
54
Original file line number Diff line number Diff line change @@ -201,6 +201,5 @@ class _BlockVisitor extends RecursiveAstVisitor<void> {
201
201
bool _haveDifferentParameterTypes (AstNode visitedInvocation, AstNode node) =>
202
202
visitedInvocation is Expression &&
203
203
node is Expression &&
204
- visitedInvocation.staticParameterElement? .type !=
205
- node.staticParameterElement? .type;
204
+ ! haveSameParameterType (visitedInvocation, node);
206
205
}
Original file line number Diff line number Diff line change @@ -43,6 +43,9 @@ bool isOverride(List<Annotation> metadata) => metadata.any(
43
43
node.name.name == 'override' && node.atSign.type == TokenType .AT ,
44
44
);
45
45
46
+ bool haveSameParameterType (Expression left, Expression right) =>
47
+ left.staticParameterElement? .type == right.staticParameterElement? .type;
48
+
46
49
bool isEntrypoint (String name, NodeList <Annotation > metadata) =>
47
50
name == 'main' ||
48
51
_hasPragmaAnnotation (metadata) ||
You can’t perform that action at this time.
0 commit comments