Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Commit cfd2474

Browse files
committed
fix: correctly available check rule names
1 parent 3c37770 commit cfd2474

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
* fix: correctly available check rule names.
6+
37
## 5.0.0
48

59
* feat: **Breaking change** rename `member-ordering-extended` to `member-ordering`, discarding the old implementation.

lib/src/analyzers/lint_analyzer/lint_analysis_options_validator.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import 'lint_analysis_config.dart';
99
import 'models/issue.dart';
1010
import 'models/lint_file_report.dart';
1111
import 'models/severity.dart';
12+
import 'rules/rules_factory.dart';
1213

1314
class LintAnalysisOptionsValidator {
1415
static LintFileReport? validateOptions(
@@ -28,11 +29,11 @@ class LintAnalysisOptionsValidator {
2829
return null;
2930
}
3031

31-
final parsedRuleIds = config.codeRules.map((rule) => rule.id).toList();
32+
final ids = allRuleIds.toSet();
3233
final issues = <Issue>[];
3334

3435
for (final rule in rulesList) {
35-
if (!parsedRuleIds.contains(rule.ruleName)) {
36+
if (!ids.contains(rule.ruleName)) {
3637
issues.add(
3738
Issue(
3839
ruleId: 'unknown-config',

lib/src/analyzers/lint_analyzer/rules/rules_factory.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,8 @@ final _implementedRules = <String, Rule Function(Map<String, Object>)>{
144144
TagNameRule.ruleId: TagNameRule.new,
145145
};
146146

147+
Iterable<String> get allRuleIds => _implementedRules.keys;
148+
147149
Iterable<Rule> get allRules =>
148150
_implementedRules.keys.map((id) => _implementedRules[id]!({}));
149151

0 commit comments

Comments
 (0)