[cfe] Use sound null safety for outline and modular suites

Change-Id: Ideee9917b2e5b819672c7e441d051f9bc57c86c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366342
Reviewed-by: Jens Johansen <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/test/fasta/modular_suite.dart

@@ -11,6 +11,7 @@ import 'testing/suite.dart';
 Future<FastaContext> createContext(
     Chain suite, Map<String, String> environment) {
   environment[EnvironmentKeys.compilationMode] = CompileMode.modular.name;
+  environment[EnvironmentKeys.soundNullSafety] = "true";
   return FastaContext.create(suite, environment);
 }
 

pkg/front_end/test/fasta/outline_suite.dart

@@ -5,10 +5,12 @@
 library fasta.test.outline_suite;
 
 import 'suite_utils.dart' show internalMain;
+import 'testing/environment_keys.dart';
 import 'testing/suite.dart';
 
 Future<FastaContext> createContext(
     Chain suite, Map<String, String> environment) {
+  environment[EnvironmentKeys.soundNullSafety] = "true";
   return FastaContext.create(suite, environment);
 }
 

pkg/front_end/testcases/agnostic/as.dart.strong.modular.expect

@@ -0,0 +1,30 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/agnostic/as.dart:5:20: Error: Constant evaluation error:
+// const a = <Null>[] as List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/as.dart:5:20: Context: Constant value is not strong/weak mode agnostic.
+// const a = <Null>[] as List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/as.dart:5:7: Context: While analyzing:
+// const a = <Null>[] as List<int>;
+//       ^
+//
+// pkg/front_end/testcases/agnostic/as.dart:6:20: Error: Constant evaluation error:
+// const b = <int?>[] as List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/as.dart:6:20: Context: Constant value is not strong/weak mode agnostic.
+// const b = <int?>[] as List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/as.dart:6:7: Context: While analyzing:
+// const b = <int?>[] as List<int>;
+//       ^
+//
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = invalid-expression "Constant value is not strong/weak mode agnostic.";
+static const field core::List<core::int> b = invalid-expression "Constant value is not strong/weak mode agnostic.";
+static method main() → void {}

pkg/front_end/testcases/agnostic/as.dart.strong.outline.expect

@@ -0,0 +1,14 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = const <Null>[] as core::List<core::int>;
+static const field core::List<core::int> b = const <core::int?>[] as core::List<core::int>;
+static method main() → void
+  ;
+
+
+Extra constant evaluation status:
+Evaluated: ListLiteral @ org-dartlang-testcase:///as.dart:5:17 -> ListConstant(const <Null>[])
+Evaluated: ListLiteral @ org-dartlang-testcase:///as.dart:6:17 -> ListConstant(const <int?>[])
+Extra constant evaluation: evaluated: 4, effectively constant: 2

pkg/front_end/testcases/agnostic/as.dart.weak.modular.expect

@@ -0,0 +1,14 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = #C1;
+static const field core::List<core::int?> b = #C2;
+static const field core::bool c = #C3;
+static method main() → dynamic {}
+
+constants  {
+  #C1 = <core::int>[]
+  #C2 = <core::int?>[]
+  #C3 = false
+}

pkg/front_end/testcases/agnostic/as.dart.weak.outline.expect

@@ -0,0 +1,16 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = const <core::int>[];
+static const field core::List<core::int?> b = const <core::int?>[];
+static const field core::bool c = core::identical(self::a, self::b);
+static method main() → dynamic
+  ;
+
+
+Extra constant evaluation status:
+Evaluated: ListLiteral @ org-dartlang-testcase:///identical.dart:5:16 -> ListConstant(const <int>[])
+Evaluated: ListLiteral @ org-dartlang-testcase:///identical.dart:6:17 -> ListConstant(const <int?>[])
+Evaluated: StaticInvocation @ org-dartlang-testcase:///identical.dart:7:11 -> BoolConstant(false)
+Extra constant evaluation: evaluated: 3, effectively constant: 3

pkg/front_end/testcases/agnostic/identical.dart.strong.modular.expect

@@ -0,0 +1,30 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/agnostic/is.dart:5:20: Error: Constant evaluation error:
+// const a = <Null>[] is List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/is.dart:5:20: Context: Constant value is not strong/weak mode agnostic.
+// const a = <Null>[] is List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/is.dart:5:7: Context: While analyzing:
+// const a = <Null>[] is List<int>;
+//       ^
+//
+// pkg/front_end/testcases/agnostic/is.dart:6:20: Error: Constant evaluation error:
+// const b = <int?>[] is List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/is.dart:6:20: Context: Constant value is not strong/weak mode agnostic.
+// const b = <int?>[] is List<int>;
+//                    ^
+// pkg/front_end/testcases/agnostic/is.dart:6:7: Context: While analyzing:
+// const b = <int?>[] is List<int>;
+//       ^
+//
+import self as self;
+import "dart:core" as core;
+
+static const field core::bool a = invalid-expression "Constant value is not strong/weak mode agnostic.";
+static const field core::bool b = invalid-expression "Constant value is not strong/weak mode agnostic.";
+static method main() → void {}

pkg/front_end/testcases/agnostic/identical.dart.strong.outline.expect

@@ -0,0 +1,14 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::bool a = const <Null>[] is core::List<core::int>;
+static const field core::bool b = const <core::int?>[] is core::List<core::int>;
+static method main() → void
+  ;
+
+
+Extra constant evaluation status:
+Evaluated: ListLiteral @ org-dartlang-testcase:///is.dart:5:17 -> ListConstant(const <Null>[])
+Evaluated: ListLiteral @ org-dartlang-testcase:///is.dart:6:17 -> ListConstant(const <int?>[])
+Extra constant evaluation: evaluated: 4, effectively constant: 2

pkg/front_end/testcases/agnostic/identical.dart.weak.modular.expect

@@ -0,0 +1,16 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = #C1;
+static const field core::List<core::int?> b = #C2;
+static const field core::Map<core::List<core::int?>, core::int> c = #C5;
+static method main() → dynamic {}
+
+constants  {
+  #C1 = <core::int>[]
+  #C2 = <core::int?>[]
+  #C3 = 0
+  #C4 = 1
+  #C5 = <core::List<core::int?>, core::int>{#C1:#C3, #C2:#C4}
+}

pkg/front_end/testcases/agnostic/identical.dart.weak.outline.expect

@@ -0,0 +1,16 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = const <core::int>[];
+static const field core::List<core::int?> b = const <core::int?>[];
+static const field core::Map<core::List<core::int?>, core::int> c = const <core::List<core::int?>, core::int>{self::a: 0, self::b: 1};
+static method main() → dynamic
+  ;
+
+
+Extra constant evaluation status:
+Evaluated: ListLiteral @ org-dartlang-testcase:///map.dart:5:16 -> ListConstant(const <int>[])
+Evaluated: ListLiteral @ org-dartlang-testcase:///map.dart:6:17 -> ListConstant(const <int?>[])
+Evaluated: MapLiteral @ org-dartlang-testcase:///map.dart:7:11 -> MapConstant(const <List<int?>, int>{const <int>[]: 0, const <int?>[]: 1})
+Extra constant evaluation: evaluated: 3, effectively constant: 3

pkg/front_end/testcases/agnostic/is.dart.strong.modular.expect

@@ -0,0 +1,14 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = #C1;
+static const field core::List<core::int?> b = #C2;
+static const field core::Set<core::List<core::int?>> c = #C3;
+static method main() → dynamic {}
+
+constants  {
+  #C1 = <core::int>[]
+  #C2 = <core::int?>[]
+  #C3 = <core::List<core::int?>>{#C1, #C2}
+}

pkg/front_end/testcases/agnostic/is.dart.strong.outline.expect

@@ -0,0 +1,16 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+static const field core::List<core::int> a = const <core::int>[];
+static const field core::List<core::int?> b = const <core::int?>[];
+static const field core::Set<core::List<core::int?>> c = const <core::List<core::int?>>{self::a, self::b};
+static method main() → dynamic
+  ;
+
+
+Extra constant evaluation status:
+Evaluated: ListLiteral @ org-dartlang-testcase:///set.dart:5:16 -> ListConstant(const <int>[])
+Evaluated: ListLiteral @ org-dartlang-testcase:///set.dart:6:17 -> ListConstant(const <int?>[])
+Evaluated: SetLiteral @ org-dartlang-testcase:///set.dart:7:11 -> SetConstant(const <List<int?>>{const <int>[], const <int?>[]})
+Extra constant evaluation: evaluated: 3, effectively constant: 3

pkg/front_end/testcases/agnostic/is.dart.weak.modular.expect

@@ -0,0 +1,20 @@
+library;
+import self as self;
+import "dart:core" as core;
+import "main_lib.dart" as mai;
+
+import "org-dartlang-testcase:///main_lib.dart";
+
+static method test() → dynamic {
+  core::Map<<unrelated T extends core::Object? = dynamic>() → mai::A<core::int?>, core::bool> m = #C6;
+  core::Map<<unrelated T extends core::Object? = dynamic>() → mai::A<core::int?>, core::bool> n = #C6;
+}
+
+constants  {
+  #C1 = constructor-tearoff mai::A::•
+  #C2 = typedef-tearoff <unrelated T extends core::Object? = dynamic>.(#C1<core::int>)
+  #C3 = true
+  #C4 = typedef-tearoff <unrelated T extends core::Object? = dynamic>.(#C1<core::int?>)
+  #C5 = false
+  #C6 = <<unrelated T extends core::Object? = dynamic>() → mai::A<core::int?>, core::bool>{#C2:#C3, #C4:#C5}
+}