Fix ruff errors in cupy/linalg

Author: adonath

array_api_compat/cupy/linalg.py

@@ -1,47 +1,61 @@
-from cupy.linalg import *
-# cupy.linalg doesn't have __all__. If it is added, replace this with
-#
-# from cupy.linalg import __all__ as linalg_all
-_n = {}
-exec('from cupy.linalg import *', _n)
-del _n['__builtins__']
-linalg_all = list(_n)
-del _n
+import cupy as cp
+from .._internal import _get_all_public_members
 
-from ..common import _linalg
-from .._internal import get_xp
-from ._aliases import (matmul, matrix_transpose, tensordot, vecdot)
+_cupy_linalg_all = _get_all_public_members(cp.linalg)
 
-import cupy as cp
+for name in _cupy_linalg_all:
+    globals()[name] = getattr(cp.linalg, name)
 
-cross = get_xp(cp)(_linalg.cross)
-outer = get_xp(cp)(_linalg.outer)
-EighResult = _linalg.EighResult
-QRResult = _linalg.QRResult
-SlogdetResult = _linalg.SlogdetResult
-SVDResult = _linalg.SVDResult
-eigh = get_xp(cp)(_linalg.eigh)
-qr = get_xp(cp)(_linalg.qr)
-slogdet = get_xp(cp)(_linalg.slogdet)
-svd = get_xp(cp)(_linalg.svd)
-cholesky = get_xp(cp)(_linalg.cholesky)
-matrix_rank = get_xp(cp)(_linalg.matrix_rank)
-pinv = get_xp(cp)(_linalg.pinv)
-matrix_norm = get_xp(cp)(_linalg.matrix_norm)
-svdvals = get_xp(cp)(_linalg.svdvals)
-diagonal = get_xp(cp)(_linalg.diagonal)
-trace = get_xp(cp)(_linalg.trace)
+from ._aliases import ( # noqa: E402
+    EighResult,
+    QRResult,
+    SlogdetResult,
+    SVDResult,
+    cholesky,
+    cross,
+    diagonal,
+    eigh,
+    matmul,
+    matrix_norm,
+    matrix_rank,
+    matrix_transpose,
+    outer,
+    pinv,
+    qr,
+    slogdet,
+    svd,
+    svdvals,
+    tensordot,
+    trace,
+    vecdot,
+    vector_norm,
+)
 
-# These functions are completely new here. If the library already has them
-# (i.e., numpy 2.0), use the library version instead of our wrapper.
-if hasattr(cp.linalg, 'vector_norm'):
-    vector_norm = cp.linalg.vector_norm
-else:
-    vector_norm = get_xp(cp)(_linalg.vector_norm)
+__all__ = []
 
-__all__ = linalg_all + _linalg.__all__
+__all__ += _cupy_linalg_all
 
-del get_xp
-del cp
-del linalg_all
-del _linalg
+__all__ += [
+    "cross",
+    "matmul",
+    "outer",
+    "tensordot",
+    "EighResult",
+    "QRResult",
+    "SlogdetResult",
+    "SVDResult",
+    "eigh",
+    "qr",
+    "slogdet",
+    "svd",
+    "cholesky",
+    "matrix_rank",
+    "pinv",
+    "matrix_norm",
+    "matrix_transpose",
+    "svdvals",
+    "vecdot",
+    "vector_norm",
+    "diagonal",
+    "trace",
+]