Skip to content

Adds pytorch to get_namespace #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2023
Merged

Adds pytorch to get_namespace #18

merged 1 commit into from
Mar 2, 2023

Conversation

thomasjpfan
Copy link
Contributor

This PR enables torch to be returned by get_namespace.

kgryte
kgryte approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rgommers
rgommers approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me too. Thanks @thomasjpfan. Given that Aaron is off this week, let me hit the green button here to keep the ball rolling.

@rgommers rgommers merged commit 945609e into data-apis:main Mar 2, 2023
@asmeurer
Copy link
Member

asmeurer commented Mar 6, 2023

Thanks for fixing this and adding a test. I guess I forgot to properly test this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @asmeurer @rgommers @kgryte