Allow symmetric_matrices to generate finite matrices

Author: asmeurer

array_api_tests/hypothesis_helpers.py

@@ -129,10 +129,11 @@ def tuples(elements, *, min_size=0, max_size=None, unique_by=None, unique=False)
 
 # Note: This should become hermitian_matrices when complex dtypes are added
 @composite
-def symmetric_matrices(draw, dtypes=xps.floating_dtypes()):
+def symmetric_matrices(draw, dtypes=xps.floating_dtypes(), finite=True):
     shape = draw(square_matrix_shapes)
     dtype = draw(dtypes)
-    a = draw(xps.arrays(dtype=dtype, shape=shape))
+    elements = {'allow_nan': False, 'allow_infinity': False} if finite else None
+    a = draw(xps.arrays(dtype=dtype, shape=shape, elements=elements))
     upper = xp.triu(a)
     lower = xp.triu(a, k=1).mT
     return upper + lower

array_api_tests/meta_tests/test_hypothesis_helpers.py

@@ -70,14 +70,20 @@ def run(kw):
     assert len(c_results) > 0
     assert all(isinstance(kw["c"], str) for kw in c_results)
 
-@given(hh.symmetric_matrices(hh.shared_floating_dtypes), hh.shared_floating_dtypes)
-def test_symmetric_matrices(m, dtype):
+@given(m=hh.symmetric_matrices(hh.shared_floating_dtypes,
+                                     finite=st.shared(st.booleans(), key='finite')),
+       dtype=hh.shared_floating_dtypes,
+       finite=st.shared(st.booleans(), key='finite'))
+def test_symmetric_matrices(m, dtype, finite):
     assert m.dtype == dtype
     # TODO: This part of this test should be part of the .mT test
     ah.assert_exactly_equal(m, m.mT)
 
+    if finite:
+        ah.assert_finite(m)
 
-@given(hh.positive_definite_matrices(hh.shared_floating_dtypes), hh.shared_floating_dtypes)
+@given(m=hh.positive_definite_matrices(hh.shared_floating_dtypes),
+       dtype=hh.shared_floating_dtypes)
 def test_positive_definite_matrices(m, dtype):
     assert m.dtype == dtype
     # TODO: Test that it actually is positive definite