Skip to content

Commit c9f2c40

Browse files
committed
Update wording on docs and warnings
1 parent 6f05d36 commit c9f2c40

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

array_api_tests/test_special_cases.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
"""
22
Tests for special cases.
33
4-
The test cases for special casing are built on runtime via the parametrized
5-
test_unary and test_binary functions. Most of this file consists of utility
4+
Most test cases for special casing are built on runtime via the parametrized
5+
tests test_unary/test_binary/test_iop. Most of this file consists of utility
66
classes and functions, all bought together to create the test cases (pytest
7-
params), to finally be run through the general test logic of either test_unary
8-
or test_binary.
7+
params), to finally be run through generalised test logic.
98
109
TODO: test integer arrays for relevant special cases
1110
"""
@@ -1165,7 +1164,7 @@ def parse_binary_case_block(case_block: str) -> List[BinaryCase]:
11651164
p = pytest.param(func_name, func, case, id=id_)
11661165
unary_params.append(p)
11671166
else:
1168-
warn("TODO")
1167+
warn(f"Special cases found for {stub.__name__} but none were parsed")
11691168
continue
11701169
if len(sig.parameters) == 1:
11711170
warn(f"{func=} has one parameter '{param_names[0]}' which is not named 'x'")
@@ -1190,7 +1189,7 @@ def parse_binary_case_block(case_block: str) -> List[BinaryCase]:
11901189
p = pytest.param(func_name, func, case, id=id_)
11911190
binary_params.append(p)
11921191
else:
1193-
warn("TODO")
1192+
warn(f"Special cases found for {stub.__name__} but none were parsed")
11941193
continue
11951194
else:
11961195
warn(
@@ -1199,7 +1198,7 @@ def parse_binary_case_block(case_block: str) -> List[BinaryCase]:
11991198
)
12001199

12011200

1202-
# test_unary and test_binary naively generate arrays, i.e. arrays that might not
1201+
# test_{unary/binary/iop} naively generate arrays, i.e. arrays that might not
12031202
# meet the condition that is being test. We then forcibly make the array meet
12041203
# the condition by picking a random index to insert an acceptable element.
12051204
#

0 commit comments

Comments
 (0)