Skip to content

MAINT: Remove legacy hook marks #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Nov 16, 2023

Hi!
When running the test suite I get an error when collecting tests:

pytest.PytestDeprecationWarning: The hookimpl pytest_json_modifyreport uses old-style configuration options (marks or attributes).
Please use the pytest.hookimpl(optionalhook=True) decorator instead
 to configure the hooks.
 See https://docs.pytest.org/en/latest/deprecations.html#configuring-hook-specs-impls-using-markers
 at /home/runner/work/numpy/numpy/array-api-tests/reporting.py:94
Error: Process completed with exit code 1.

The first CI run in my fork: https://github.com/mtsokol/numpy/actions/runs/6894487016/job/18756394760

Here's a small patch that updates decorators.

@asmeurer
Copy link
Member

Should verify this manually. I don't think we generate JSON on CI.

@honno
Copy link
Member

honno commented Dec 1, 2023

Thanks for the PR!! Closing this though as its resolved by #218 now.

@honno honno closed this Dec 1, 2023
@mtsokol mtsokol deleted the legacy-hook-marks branch December 1, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants