Skip to content

MAINT: Add pytest.ini file #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2023
Merged

MAINT: Add pytest.ini file #217

merged 1 commit into from
Nov 26, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Nov 24, 2023

Hi!

A small change: Due to the fact that here's no pytest.ini, a wrong rootdir gets picked in the downstream libs CI. E.g. in https://github.com/mtsokol/numpy/actions/runs/6982999059/job/19003296323?pr=4, there's rootdir: /home/runner/work/numpy/numpy instead of ${GITHUB_WORKSPACE}/array-api-tests.

Also discussed here: pytest-dev/pytest#11636

Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah makes sense, thanks!

@honno honno merged commit d264bad into data-apis:master Nov 26, 2023
@mtsokol mtsokol deleted the pytest-file branch November 26, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants