Skip to content

Update test_sign for complex inputs #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2024
Merged

Update test_sign for complex inputs #227

merged 2 commits into from
Jan 10, 2024

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Jan 2, 2024

Hi!
This PR updates test_sign for complex inputs to align with Array API.

Relevant discussion: numpy/numpy#25441 (comment)

@honno honno self-requested a review January 8, 2024 20:16
honno
honno approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I replaced use of xp.abs with math.abs, as refimpl only pertains to Python scalars as opposed to 0d arrays.

@honno honno merged commit ae0017a into data-apis:master Jan 10, 2024
@mtsokol mtsokol deleted the update-test-sign branch January 10, 2024 15:08
@mtsokol mtsokol mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honno honno honno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @honno