Update slogdet guidance for when the determinant is zero
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
Maintenance
leofang
approved these changes
Nov 4, 2021
|
Thanks @leofang! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
linalg.slogdetfor when the determinant is zero. The original language stemmed from NumPy; however, the guidance there is more conceptual than grounded in practice due to errors in numerical precision (see BUG: slogdet does not return -inf when det returns 0 numpy/numpy#20114). Accordingly, this PR loosens restrictions around return values when the determinant is0. Namely, the result should be sign0and logabsdet-inf, but may not be due to numerical precision errors.