Skip to content

Make it clearer that the dtype kinds in isdtype are the string inputs #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2023
Merged

Make it clearer that the dtype kinds in isdtype are the string inputs #610

merged 1 commit into from
Mar 14, 2023

Conversation

asmeurer
Copy link
Member

No description provided.

@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Mar 14, 2023
rgommers
rgommers approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aaron, I agree that this looks better and helps shows that these are the string inputs. In it goes.

@rgommers rgommers merged commit 94a24c8 into data-apis:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmeurer @rgommers